Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

allow duplicated bootstrap allreduce overwrite previous results (#128)

Browse Source 
* allow timeout to 0 to eanble immediate exit

* disable duplicated signature check, overwrite results with same key
This commit is contained in:
Chen Qin 2019-11-12 18:19:58 -08:00 committed by Jiaming Yuan
parent 1907b25cd0
commit 493ad834a1
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/allreduce_robust.cc
View File

@ -108,7 +108,9 @@ int AllreduceRobust::SetBootstrapCache(const std::string &key, const void *buf,
break; break;
} }
} }
_assert(index == -1, "immutable cache key already exists"); // we should consider way to support duplicated signatures
// https://github.com/dmlc/xgboost/issues/5012
// _assert(index == -1, "immutable cache key already exists");
_assert(type_nbytes*count > 0, "can't set empty cache"); _assert(type_nbytes*count > 0, "can't set empty cache");
void* temp = cachebuf.AllocTemp(type_nbytes, count); void* temp = cachebuf.AllocTemp(type_nbytes, count);
cachebuf.PushTemp(cur_cache_seq, type_nbytes, count); cachebuf.PushTemp(cur_cache_seq, type_nbytes, count);