From 493ad834a1102fcf355a250a3bd08937066cda08 Mon Sep 17 00:00:00 2001 From: Chen Qin Date: Tue, 12 Nov 2019 18:19:58 -0800 Subject: [PATCH] allow duplicated bootstrap allreduce overwrite previous results (#128) * allow timeout to 0 to eanble immediate exit * disable duplicated signature check, overwrite results with same key --- src/allreduce_robust.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/allreduce_robust.cc b/src/allreduce_robust.cc index e3db64c44..22a60c923 100644 --- a/src/allreduce_robust.cc +++ b/src/allreduce_robust.cc @@ -108,7 +108,9 @@ int AllreduceRobust::SetBootstrapCache(const std::string &key, const void *buf, break; } } - _assert(index == -1, "immutable cache key already exists"); + // we should consider way to support duplicated signatures + // https://github.com/dmlc/xgboost/issues/5012 + // _assert(index == -1, "immutable cache key already exists"); _assert(type_nbytes*count > 0, "can't set empty cache"); void* temp = cachebuf.AllocTemp(type_nbytes, count); cachebuf.PushTemp(cur_cache_seq, type_nbytes, count);