Merge pull request #906 from CodingCat/style

apply google-java-style indentation and impose import orders

jvm-packages/checkstyle.xml

@@ -76,7 +76,6 @@
             <property name="allowByTailComment" value="true"/>
             <property name="allowNonPrintableEscapes" value="true"/>
         </module>
-        <!-- TODO: 11/09/15 disabled - the lengths are currently > 100 in many places -->
         
         <module name="LineLength">
             <property name="max" value="100"/>
@@ -129,25 +128,19 @@
              <message key="ws.notPreceded"
              value="GenericWhitespace ''{0}'' is not preceded with whitespace."/>
         </module>
-        <!-- TODO: 11/09/15 disabled - indentation is currently inconsistent -->
-        <!--
         <module name="Indentation">
-            <property name="basicOffset" value="4"/>
+            <property name="basicOffset" value="2"/>
             <property name="braceAdjustment" value="0"/>
-            <property name="caseIndent" value="4"/>
+            <property name="caseIndent" value="2"/>
             <property name="throwsIndent" value="4"/>
             <property name="lineWrappingIndentation" value="4"/>
-            <property name="arrayInitIndent" value="4"/>
+            <property name="arrayInitIndent" value="2"/>
         </module>
-        -->
-        <!-- TODO: 11/09/15 disabled - order is currently wrong in many places -->
-        <!--
         <module name="ImportOrder">
             <property name="separated" value="true"/>
             <property name="ordered" value="true"/>
-            <property name="groups" value="/^javax?\./,scala,*,org.apache.spark"/>
+            <property name="groups" value="/^javax?\./,scala,*,ml.dmlc.xgboost4j"/>
         </module>
-        -->
         <module name="MethodParamPad"/>
         <module name="AnnotationLocation">
             <property name="tokens" value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF"/>

jvm-packages/xgboost4j-demo/src/main/java/ml/dmlc/xgboost4j/demo/CustomObjective.java

@@ -19,10 +19,11 @@ import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
 
-import ml.dmlc.xgboost4j.*;
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 
+import ml.dmlc.xgboost4j.*;
+
 /**
  * an example user define objective and eval
  * NOTE: when you do customized loss function, the default prediction value is margin

jvm-packages/xgboost4j-demo/src/main/java/ml/dmlc/xgboost4j/demo/DistTrain.java

@@ -1,15 +1,9 @@
 package ml.dmlc.xgboost4j.demo;
 
-import java.io.File;
 import java.io.IOException;
-import java.util.Arrays;
 import java.util.HashMap;
 
-import ml.dmlc.xgboost4j.Rabit;
+import ml.dmlc.xgboost4j.*;
-import ml.dmlc.xgboost4j.Booster;
-import ml.dmlc.xgboost4j.DMatrix;
-import ml.dmlc.xgboost4j.XGBoost;
-import ml.dmlc.xgboost4j.XGBoostError;
 
 /**
  * Distributed training example, used to quick test distributed training.

jvm-packages/xgboost4j-demo/src/main/java/ml/dmlc/xgboost4j/demo/GeneralizedLinearModel.java

@@ -15,14 +15,14 @@
  */
 package ml.dmlc.xgboost4j.demo;
 
+import java.util.HashMap;
+
 import ml.dmlc.xgboost4j.Booster;
 import ml.dmlc.xgboost4j.DMatrix;
 import ml.dmlc.xgboost4j.XGBoost;
 import ml.dmlc.xgboost4j.XGBoostError;
 import ml.dmlc.xgboost4j.demo.util.CustomEval;
 
-import java.util.HashMap;
-
 /**
  * this is an example of fit generalized linear model in xgboost
  * basically, we are using linear model, instead of tree for our boosters

jvm-packages/xgboost4j-demo/src/main/java/ml/dmlc/xgboost4j/demo/util/CustomEval.java

@@ -17,6 +17,7 @@ package ml.dmlc.xgboost4j.demo.util;
 
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
+
 import ml.dmlc.xgboost4j.DMatrix;
 import ml.dmlc.xgboost4j.IEvaluation;
 import ml.dmlc.xgboost4j.XGBoostError;

jvm-packages/xgboost4j-demo/src/main/java/ml/dmlc/xgboost4j/demo/util/DataLoader.java

@@ -15,12 +15,12 @@
  */
 package ml.dmlc.xgboost4j.demo.util;
 
-import org.apache.commons.lang3.ArrayUtils;
-
 import java.io.*;
 import java.util.ArrayList;
 import java.util.List;
 
+import org.apache.commons.lang3.ArrayUtils;
+
 /**
  * util class for loading data
  *

jvm-packages/xgboost4j/src/main/java/ml/dmlc/xgboost4j/DMatrix.java

@@ -15,11 +15,11 @@
  */
 package ml.dmlc.xgboost4j;
 
+import java.io.IOException;
+
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 
-import java.io.IOException;
-
 /**
  * DMatrix for xgboost.
  *

jvm-packages/xgboost4j/src/main/java/ml/dmlc/xgboost4j/JNIErrorHandle.java

@@ -15,11 +15,11 @@
  */
 package ml.dmlc.xgboost4j;
 
+import java.io.IOException;
+
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 
-import java.io.IOException;
-
 /**
  * Error handle for Xgboost.
  */

jvm-packages/xgboost4j/src/main/java/ml/dmlc/xgboost4j/JavaBoosterImpl.java

@@ -15,14 +15,13 @@
  */
 package ml.dmlc.xgboost4j;
 
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
-
 import java.io.*;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 
 /**
  * Booster for xgboost, similar to the python wrapper xgboost.py

jvm-packages/xgboost4j/src/main/java/ml/dmlc/xgboost4j/NativeLibLoader.java

@@ -15,12 +15,12 @@
  */
 package ml.dmlc.xgboost4j;
 
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
-
 import java.io.*;
 import java.lang.reflect.Field;
 
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+
 /**
  * class to load native library
  *

jvm-packages/xgboost4j/src/main/java/ml/dmlc/xgboost4j/Rabit.java

@@ -1,9 +1,10 @@
 package ml.dmlc.xgboost4j;
 
+import java.io.IOException;
+import java.util.Map;
+
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
-import java.util.Map;
-import java.io.IOException;
 
 /**
  * Rabit global class for synchronization.

jvm-packages/xgboost4j/src/main/java/ml/dmlc/xgboost4j/XGBoost.java

@@ -15,11 +15,10 @@
  */
 package ml.dmlc.xgboost4j;
 
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
-
 import java.util.*;
 
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 
 /**
  * trainer for xgboost

jvm-packages/xgboost4j/src/main/scala/ml/dmlc/xgboost4j/scala/ScalaBoosterImpl.scala

@@ -19,7 +19,7 @@ package ml.dmlc.xgboost4j.scala
 import scala.collection.JavaConverters._
 import scala.collection.mutable
 
-import ml.dmlc.xgboost4j.{Booster => JBooster, IEvaluation, IObjective}
+import ml.dmlc.xgboost4j.{Booster => JBooster}
 
 private[scala] class ScalaBoosterImpl private[xgboost4j](booster: JBooster) extends Booster {
 

jvm-packages/xgboost4j/src/main/scala/ml/dmlc/xgboost4j/scala/XGBoost.scala

@@ -16,7 +16,8 @@
 
 package ml.dmlc.xgboost4j.scala
 
-import _root_.scala.collection.JavaConverters._
+import scala.collection.JavaConverters._
+
 import ml.dmlc.xgboost4j.{XGBoost => JXGBoost}
 
 object XGBoost {

jvm-packages/xgboost4j/src/test/java/ml/dmlc/xgboost4j/BoosterImplTest.java

@@ -15,13 +15,14 @@
  */
 package ml.dmlc.xgboost4j;
 
+import java.util.HashMap;
+import java.util.Map;
+
 import junit.framework.TestCase;
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.junit.Test;
 
-import java.util.*;
-
 /**
  * test cases for Booster
  *

jvm-packages/xgboost4j/src/test/java/ml/dmlc/xgboost4j/DMatrixTest.java

@@ -15,12 +15,12 @@
  */
 package ml.dmlc.xgboost4j;
 
-import junit.framework.TestCase;
-import org.junit.Test;
-
 import java.util.Arrays;
 import java.util.Random;
 
+import junit.framework.TestCase;
+import org.junit.Test;
+
 /**
  * test cases for DMatrix
  *

rabit

@@ -1 +1 @@
-Subproject commit be50e7b63224b9fb7ff94ce34df9f8752ef83043
+Subproject commit 1392e9f3da59bd5602ddebee944dd8fb5c6507b0