History

Philip Hyunsu Cho b38c636d05

Fix #3523 : Fix CustomGlobalRandomEngine for R (#3781 )

**Symptom** Apple Clang's implementation of `std::shuffle` expects doesn't work
correctly when it is run with the random bit generator for R package:
```cpp
CustomGlobalRandomEngine::result_type
CustomGlobalRandomEngine::operator()() {
  return static_cast<result_type>(
      std::floor(unif_rand() * CustomGlobalRandomEngine::max()));
}
```

Minimial reproduction of failure (compile using Apple Clang 10.0):
```cpp
std::vector<int> feature_set(100);
std::iota(feature_set.begin(), feature_set.end(), 0);
    // initialize with 0, 1, 2, 3, ..., 99
std::shuffle(feature_set.begin(), feature_set.end(), common::GlobalRandom());
    // This returns 0, 1, 2, ..., 99, so content didn't get shuffled at all!!!
```

Note that this bug is platform-dependent; it does not appear when GCC or
upstream LLVM Clang is used.

**Diagnosis** Apple Clang's `std::shuffle` expects 32-bit integer
inputs, whereas `CustomGlobalRandomEngine::operator()` produces 64-bit
integers.

**Fix** Have `CustomGlobalRandomEngine::operator()` produce 32-bit integers.

Closes #3523.

2018-10-15 09:39:13 -07:00

data

resolving not-CRAN issues

2015-01-20 15:51:42 -08:00

demo

fix R check warning (#3728 )

2018-09-27 17:53:49 -07:00

man

[R] R-interface for SHAP interactions (#3636 )

2018-08-30 19:06:21 -05:00

Amend xgb.createFolds to handle classes of a single element. (#3630 )

2018-09-12 09:23:05 -05:00