Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Deprecation warning for lists passed into DMatrix (#3970)

Browse Source 
* Ensure lists cannot be passed into DMatrix

The documentation does not include lists as an allowed type for the data inputted into DMatrix. Despite this, a list can be passed in without an error. This change would prevent a list form being passed in directly.
This commit is contained in:
Sam Wilkinson 2018-12-14 06:26:11 -05:00 committed by Jiaming Yuan
parent 53f695acf2
commit fd722d60cd
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
python-package/xgboost/core.py
View File

@ -14,6 +14,7 @@ import ctypes
import os import os
import re import re
import sys import sys
import warnings
import numpy as np import numpy as np
import scipy.sparse import scipy.sparse
@ -381,6 +382,10 @@ class DMatrix(object):
label = _maybe_dt_array(label) label = _maybe_dt_array(label)
weight = _maybe_dt_array(weight) weight = _maybe_dt_array(weight)
if isinstance(data, list):
warnings.warn('Initializing DMatrix from List is deprecated.',
DeprecationWarning)
if isinstance(data, STRING_TYPES): if isinstance(data, STRING_TYPES):
self.handle = ctypes.c_void_p() self.handle = ctypes.c_void_p()
_check_call(_LIB.XGDMatrixCreateFromFile(c_str(data), _check_call(_LIB.XGDMatrixCreateFromFile(c_str(data),