From f83e62dca58754d4ad89e76decf7dab2d4bd9ae6 Mon Sep 17 00:00:00 2001 From: Philip Hyunsu Cho Date: Fri, 8 Mar 2019 17:11:42 -0800 Subject: [PATCH] Address #4042: Prevent out-of-range access in column matrix (#4231) --- src/common/column_matrix.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/common/column_matrix.h b/src/common/column_matrix.h index 9822593e9..4a1ab918d 100644 --- a/src/common/column_matrix.h +++ b/src/common/column_matrix.h @@ -163,7 +163,8 @@ class ColumnMatrix { to determine type of bin id's */ inline Column GetColumn(unsigned fid) const { Column c(type_[fid], &index_[boundary_[fid].index_begin], index_base_[fid], - &row_ind_[boundary_[fid].row_ind_begin], + (type_[fid] == ColumnType::kSparseColumn ? + &row_ind_[boundary_[fid].row_ind_begin] : nullptr), boundary_[fid].index_end - boundary_[fid].index_begin); return c; }