Use configure_file() to configure version only (#4974)

* Avoid writing build_config.h

* Remove build_config.h all together.

* Lint.

src/CMakeLists.txt

@@ -64,6 +64,17 @@ target_compile_definitions(objxgboost
   $<$<NOT:$<CXX_COMPILER_ID:MSVC>>:_MWAITXINTRIN_H_INCLUDED>
   ${XGBOOST_DEFINITIONS})
 
+if (XGBOOST_MM_PREFETCH_PRESENT)
+  target_compile_definitions(objxgboost
+    PRIVATE
+    -DXGBOOST_MM_PREFETCH_PRESENT=1)
+endif(XGBOOST_MM_PREFETCH_PRESENT)
+if (XGBOOST_BUILTIN_PREFETCH_PRESENT)
+  target_compile_definitions(objxgboost
+    PRIVATE
+    -DXGBOOST_BUILTIN_PREFETCH_PRESENT=1)
+endif (XGBOOST_BUILTIN_PREFETCH_PRESENT)
+
 if (USE_OPENMP)
   find_package(OpenMP REQUIRED)
   if (OpenMP_CXX_FOUND OR OPENMP_FOUND)

src/c_api/c_api.cc

@@ -1,10 +1,4 @@
 // Copyright (c) 2014-2019 by Contributors
-
-#include <xgboost/data.h>
-#include <xgboost/learner.h>
-#include <xgboost/c_api.h>
-#include <xgboost/logging.h>
-
 #include <dmlc/thread_local.h>
 #include <rabit/rabit.h>
 #include <rabit/c_api.h>
@@ -16,6 +10,12 @@
 #include <string>
 #include <memory>
 
+#include "xgboost/data.h"
+#include "xgboost/learner.h"
+#include "xgboost/c_api.h"
+#include "xgboost/logging.h"
+#include "xgboost/version_config.h"
+
 #include "c_api_error.h"
 #include "../data/simple_csr_source.h"
 #include "../common/math.h"

src/common/hist_util.cc

@@ -2,14 +2,16 @@
  * Copyright 2017-2019 by Contributors
   * \file hist_util.cc
  */
-#include "./hist_util.h"
 #include <dmlc/timer.h>
-#include <rabit/rabit.h>
 #include <dmlc/omp.h>
+
+#include <rabit/rabit.h>
 #include <numeric>
 #include <vector>
 
+#include "xgboost/base.h"
 #include "../common/common.h"
+#include "./hist_util.h"
 #include "./random.h"
 #include "./column_matrix.h"
 #include "./quantile.h"

src/common/version.cc

@@ -9,6 +9,7 @@
 
 #include "xgboost/logging.h"
 #include "xgboost/json.h"
+#include "xgboost/version_config.h"
 #include "version.h"
 
 namespace xgboost {

src/data/data.cc

@@ -2,15 +2,16 @@
  * Copyright 2015-2019 by Contributors
  * \file data.cc
  */
-#include <xgboost/data.h>
-#include <xgboost/logging.h>
-#include <xgboost/build_config.h>
 #include <dmlc/registry.h>
 #include <cstring>
 
-#include "./sparse_page_writer.h"
-#include "./simple_dmatrix.h"
-#include "./simple_csr_source.h"
+#include "xgboost/data.h"
+#include "xgboost/logging.h"
+#include "xgboost/version_config.h"
+#include "sparse_page_writer.h"
+#include "simple_dmatrix.h"
+#include "simple_csr_source.h"
+
 #include "../common/io.h"
 #include "../common/version.h"
 #include "../common/group_data.h"