Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove some warnings from clang. (#7533)

Browse Source 
* Unused variable.
* Unnecessary virtual function.
This commit is contained in:
Jiaming Yuan 2022-01-05 03:28:21 +08:00 committed by GitHub
parent ec56d5869b
commit eea094e1bc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/xgboost/json_io.h
View File

@ -115,12 +115,10 @@ class JsonReader {
class JsonWriter { class JsonWriter {
static constexpr size_t kIndentSize = 2; static constexpr size_t kIndentSize = 2;
size_t n_spaces_;
std::vector<char>* stream_; std::vector<char>* stream_;
public: public:
explicit JsonWriter(std::vector<char>* stream) : explicit JsonWriter(std::vector<char>* stream) : stream_{stream} {}
n_spaces_{0}, stream_{stream} {}
virtual ~JsonWriter() = default; virtual ~JsonWriter() = default;

2
src/c_api/c_api_utils.h
View File

@ -165,9 +165,9 @@ inline float GetMissing(Json const &config) {
// Safe guard some global variables from being changed by XGBoost. // Safe guard some global variables from being changed by XGBoost.
class XGBoostAPIGuard { class XGBoostAPIGuard {
#if defined(XGBOOST_USE_CUDA)
int32_t device_id_ {0}; int32_t device_id_ {0};
#if defined(XGBOOST_USE_CUDA)
void SetGPUAttribute(); void SetGPUAttribute();
void RestoreGPUAttribute(); void RestoreGPUAttribute();
#else #else

7
src/tree/updater_quantile_hist.h
View File

@ -166,11 +166,8 @@ class QuantileHistMaker: public TreeUpdater {
builder_monitor_.Init("Quantile::Builder"); builder_monitor_.Init("Quantile::Builder");
} }
// update one tree, growing // update one tree, growing
virtual void Update(const GHistIndexMatrix& gmat, void Update(const GHistIndexMatrix& gmat, const ColumnMatrix& column_matrix,
const ColumnMatrix& column_matrix, HostDeviceVector<GradientPair>* gpair, DMatrix* p_fmat, RegTree* p_tree);
HostDeviceVector<GradientPair>* gpair,
DMatrix* p_fmat,
RegTree* p_tree);
bool UpdatePredictionCache(const DMatrix* data, bool UpdatePredictionCache(const DMatrix* data,
linalg::VectorView<float> out_preds); linalg::VectorView<float> out_preds);