Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

workaround macosx java test race condition (#74)

Browse Source 
* fix error in dmlc#57, clean up comments and naming

* include missing packages, disable recovery tests for now

* disable local_recover tests until we have a bug fix

* support larger cluster

* fix lint, merge with master

* fix mac osx test failure in https://github.com/dmlc/xgboost/pull/3818

* Update allreduce_robust.cc
This commit is contained in:
Chen Qin 2018-10-26 12:39:31 -07:00 committed by Nan Zhu
parent 3a35dabfae
commit eb2590b774
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/allreduce_robust.cc
View File

@ -50,6 +50,12 @@ void AllreduceRobust::Shutdown(void) {
// execute check ack step, load happens here // execute check ack step, load happens here
utils::Assert(RecoverExec(NULL, 0, ActionSummary::kCheckAck, ActionSummary::kSpecialOp), utils::Assert(RecoverExec(NULL, 0, ActionSummary::kCheckAck, ActionSummary::kSpecialOp),
"Shutdown: check ack must return true"); "Shutdown: check ack must return true");
#ifdef __APPLE__
// In OSX, one worker shutdowns and closes sockets while rest still run kCheckAck
// This cause rest workers checkandrecover and hang inf, https://github.com/dmlc/xgboost/pull/3818
// TODO: a fundamental fix for this
sleep(2);
#endif
AllreduceBase::Shutdown(); AllreduceBase::Shutdown();
} }
/*! /*!