From e92641887b051b6f24f76aebafc057a804187933 Mon Sep 17 00:00:00 2001
From: Xu Xiao <lovedreamf@gmail.com>
Date: Thu, 19 Sep 2019 11:06:59 +0800
Subject: [PATCH] remove unreached code of AllreduceRobust::CheckAndRecover
 (#108)

---
 src/allreduce_robust.cc | 26 +++++---------------------
 1 file changed, 5 insertions(+), 21 deletions(-)

diff --git a/src/allreduce_robust.cc b/src/allreduce_robust.cc
index fa732bd26..ec25b7d98 100644
--- a/src/allreduce_robust.cc
+++ b/src/allreduce_robust.cc
@@ -611,28 +611,12 @@ bool AllreduceRobust::CheckAndRecover(ReturnType err_type) {
   if (err_type == kSuccess) return true;
   utils::Assert(err_link != NULL, "must know the error source");
   recover_counter += 1;
-  {
-    // simple way, shutdown all links
-    for (size_t i = 0; i < all_links.size(); ++i) {
-      if (!all_links[i].sock.BadSocket()) all_links[i].sock.Close();
-    }
-    ReConnectLinks("recover");
-    return false;
-  }
-  // this was old way
-  // TryResetLinks still causes possible errors, so not use this one
-  while (err_type != kSuccess) {
-    switch (err_type.value) {
-      case kGetExcept: err_type = TryResetLinks(); break;
-      case kSockError: {
-        TryResetLinks();
-        ReConnectLinks();
-        err_type = kSuccess;
-        break;
-      }
-      default: utils::Assert(false, "RecoverLinks: cannot reach here");
-    }
+
+  // simple way, shutdown all links
+  for (size_t i = 0; i < all_links.size(); ++i) {
+    if (!all_links[i].sock.BadSocket()) all_links[i].sock.Close();
   }
+  ReConnectLinks("recover");
   return false;
 }
 /*!