Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix compiler warning in JSON IO. (#8031)

Browse Source 
Co-authored-by: Hyunsu Cho <chohyu01@cs.washington.edu>
This commit is contained in:
Jiaming Yuan 2022-06-30 01:13:22 +08:00 committed by GitHub
parent dcaf580476
commit e88d6e071d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
include/xgboost/json_io.h
View File

@ -17,6 +17,22 @@
#include <vector>
namespace xgboost {
namespace detail {
// Whether char is signed is undefined, as a result we might or might not need
// static_cast and std::to_string.
template <typename Char, std::enable_if_t<std::is_signed<Char>::value>* = nullptr>
std::string CharToStr(Char c) {
static_assert(std::is_same<Char, char>::value, "");
return std::string{c};
}
template <typename Char, std::enable_if_t<!std::is_signed<Char>::value>* = nullptr>
std::string CharToStr(Char c) {
static_assert(std::is_same<Char, char>::value, "");
return (c <= static_cast<char>(127) ? std::string{c} : std::to_string(c));
}
} // namespace detail
/*
* \brief A json reader, currently error checking and utf-8 is not fully supported.
*/
@ -89,7 +105,7 @@ class JsonReader {
} else if (got == 0) {
msg += "\\0\"";
} else {
msg += (got <= static_cast<char>(127) ? std::string{got} : std::to_string(got)) + " \"";
msg += detail::CharToStr(got) + " \"";
}
Error(msg);
}