From 6a5eb477897d0379129852118daadba91a12d844 Mon Sep 17 00:00:00 2001 From: Wojciech Migda Date: Sat, 26 Mar 2016 19:42:58 +0100 Subject: [PATCH 1/2] XGBoosterCreate api unified to use const DMatrix[] argument --- include/xgboost/c_api.h | 2 +- src/c_api/c_api.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/xgboost/c_api.h b/include/xgboost/c_api.h index 68f35ace9..1598aac3b 100644 --- a/include/xgboost/c_api.h +++ b/include/xgboost/c_api.h @@ -266,7 +266,7 @@ XGB_DLL int XGDMatrixNumCol(DMatrixHandle handle, * \param out handle to the result booster * \return 0 when success, -1 when failure happens */ -XGB_DLL int XGBoosterCreate(void* dmats[], +XGB_DLL int XGBoosterCreate(const DMatrixHandle dmats[], bst_ulong len, BoosterHandle *out); /*! diff --git a/src/c_api/c_api.cc b/src/c_api/c_api.cc index d0ea7815b..6ee4f93dc 100644 --- a/src/c_api/c_api.cc +++ b/src/c_api/c_api.cc @@ -463,7 +463,7 @@ int XGDMatrixNumCol(const DMatrixHandle handle, } // xgboost implementation -int XGBoosterCreate(DMatrixHandle dmats[], +int XGBoosterCreate(const DMatrixHandle dmats[], bst_ulong len, BoosterHandle *out) { API_BEGIN(); From daeee84e4d88f35c825e4c898b6345dfe14013be Mon Sep 17 00:00:00 2001 From: CodingCat Date: Mon, 28 Mar 2016 19:02:37 -0400 Subject: [PATCH 2/2] update doc --- doc/jvm/index.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/jvm/index.md b/doc/jvm/index.md index a6e731c54..e9a16477e 100644 --- a/doc/jvm/index.md +++ b/doc/jvm/index.md @@ -13,6 +13,8 @@ Before you install XGBoost4J, you need to define environment variable `JAVA_HOME After your `JAVA_HOME` is defined correctly, it is as simple as run `mvn package` under jvm-packages directory to install XGBoost4J. +NOTE: XGBoost4J requires to run with Spark 1.6 or newer + Contents -------- * [Java Overview Tutorial](java_intro.md)