Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Disable invalid check for completely sparse batch that results in failed assertion for issue #1827 (#2213)

Browse Source
This commit is contained in:
Alex Bain 2017-04-21 09:28:02 -07:00 committed by Tianqi Chen
parent 392aa6d1d3
commit dbaa5d0bdf
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/data/simple_csr_source.cc
View File

@ -41,7 +41,12 @@ void SimpleCSRSource::CopyFrom(dmlc::Parser<uint32_t>* parser) {
if (batch.weight != nullptr) { if (batch.weight != nullptr) {
info.weights.insert(info.weights.end(), batch.weight, batch.weight + batch.size); info.weights.insert(info.weights.end(), batch.weight, batch.weight + batch.size);
} }
CHECK(batch.index != nullptr); // Remove the assertion on batch.index, which can be null in the case that the data in this
// batch is entirely sparse. Although it's true that this indicates a likely issue with the
// user's data workflows, passing XGBoost entirely sparse data should not cause it to fail.
// See https://github.com/dmlc/xgboost/issues/1827 for complete detail.
// CHECK(batch.index != nullptr);
// update information // update information
this->info.num_row += batch.size; this->info.num_row += batch.size;
// copy the data over // copy the data over