Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "Remove warning about memset. (#6003)" (#6020)

Browse Source 
This reverts commit 12e3fb6a6cb601c58d39ed54253e6e50f1513ccc.
This commit is contained in:
Jiaming Yuan 2020-08-17 20:10:15 +08:00 committed by GitHub
parent 511bb22ffd
commit d240463b38
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/common/hist_util.cc
View File

@ -500,13 +500,13 @@ void GHistIndexBlockMatrix::Init(const GHistIndexMatrix& gmat,
*/ */
template<typename GradientSumT> template<typename GradientSumT>
void InitilizeHistByZeroes(GHistRow<GradientSumT> hist, size_t begin, size_t end) { void InitilizeHistByZeroes(GHistRow<GradientSumT> hist, size_t begin, size_t end) {
static_assert(sizeof(xgboost::detail::GradientPairInternal<GradientSumT>) % #if defined(XGBOOST_STRICT_R_MODE) && XGBOOST_STRICT_R_MODE == 1
sizeof(GradientSumT) == std::fill(hist.begin() + begin, hist.begin() + end,
0, xgboost::detail::GradientPairInternal<GradientSumT>());
""); #else // defined(XGBOOST_STRICT_R_MODE) && XGBOOST_STRICT_R_MODE == 1
auto p_data = reinterpret_cast<GradientSumT*>(hist.data()); memset(hist.data() + begin, '\0', (end-begin)*
memset(p_data + begin, '\0', (end-begin)*
sizeof(xgboost::detail::GradientPairInternal<GradientSumT>)); sizeof(xgboost::detail::GradientPairInternal<GradientSumT>));
#endif // defined(XGBOOST_STRICT_R_MODE) && XGBOOST_STRICT_R_MODE == 1
} }
template void InitilizeHistByZeroes(GHistRow<float> hist, size_t begin, template void InitilizeHistByZeroes(GHistRow<float> hist, size_t begin,
size_t end); size_t end);