diff --git a/R-package/R/xgb.train.R b/R-package/R/xgb.train.R index 32e939484..b2b226559 100644 --- a/R-package/R/xgb.train.R +++ b/R-package/R/xgb.train.R @@ -267,7 +267,7 @@ xgb.train <- function(params = list(), data, nrounds, watchlist = list(), } # evaluation printing callback - params <- c(params, list(silent = ifelse(verbose > 1, 0, 1))) + params <- c(params) print_every_n <- max( as.integer(print_every_n), 1L) if (!has.callbacks(callbacks, 'cb.print.evaluation') && verbose) { diff --git a/R-package/tests/testthat/test_basic.R b/R-package/tests/testthat/test_basic.R index eb881ed46..733c38080 100644 --- a/R-package/tests/testthat/test_basic.R +++ b/R-package/tests/testthat/test_basic.R @@ -314,7 +314,7 @@ test_that("colsample_bytree works", { watchlist <- list(train = dtrain, eval = dtest) # Use colsample_bytree = 0.01, so that roughly one out of 100 features is # chosen for each tree - param <- list(max_depth = 2, eta = 0, silent = 1, nthread = 2, + param <- list(max_depth = 2, eta = 0, verbosity = 0, nthread = 2, colsample_bytree = 0.01, objective = "binary:logistic", eval_metric = "auc") set.seed(2) diff --git a/doc/parameter.rst b/doc/parameter.rst index 9bc328b45..d31091fec 100644 --- a/doc/parameter.rst +++ b/doc/parameter.rst @@ -23,10 +23,6 @@ General Parameters - Which booster to use. Can be ``gbtree``, ``gblinear`` or ``dart``; ``gbtree`` and ``dart`` use tree based models while ``gblinear`` uses linear functions. -* ``silent`` [default=0] [Deprecated] - - - Deprecated. Please use ``verbosity`` instead. - * ``verbosity`` [default=1] - Verbosity of printing messages. Valid values are 0 (silent), 1 (warning), 2 (info), 3 diff --git a/include/xgboost/logging.h b/include/xgboost/logging.h index e05464faf..07a2e67cf 100644 --- a/include/xgboost/logging.h +++ b/include/xgboost/logging.h @@ -37,13 +37,9 @@ class BaseLogger { // Parsing both silent and debug_verbose is to provide backward compatibility. struct ConsoleLoggerParam : public XGBoostParameter { - bool silent; // deprecated. int verbosity; DMLC_DECLARE_PARAMETER(ConsoleLoggerParam) { - DMLC_DECLARE_FIELD(silent) - .set_default(false) - .describe("Do not print information during training."); DMLC_DECLARE_FIELD(verbosity) .set_range(0, 3) .set_default(1) // shows only warning diff --git a/src/logging.cc b/src/logging.cc index f6fa4c07f..f03e1be02 100644 --- a/src/logging.cc +++ b/src/logging.cc @@ -53,12 +53,6 @@ bool ConsoleLogger::ShouldLog(LogVerbosity verbosity) { void ConsoleLogger::Configure(Args const& args) { param_.UpdateAllowUnknown(args); - // Deprecated, but when trying to display deprecation message some R - // tests trying to catch stdout will fail. - if (param_.silent) { - global_verbosity_ = LogVerbosity::kSilent; - return; - } switch (param_.verbosity) { case 0: global_verbosity_ = LogVerbosity::kSilent;