Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Restrict access to cfg_ in gbm. (#4801)

Browse Source 
* Restrict access to `cfg_` in gbm.

* Verify having correct updaters.

* Remove `grow_global_histmaker`

This updater is the same as `grow_histmaker`.  The former is not in our
document so we just remove it.
This commit is contained in:
Jiaming Yuan
2019-09-02 00:43:19 -04:00
committed by GitHub
parent 2aed0ae230
commit c0fbeff0ab
7 changed files with 99 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/tree/updater_gpu_hist.cu
View File

@@ -1460,7 +1460,7 @@ class GPUHistMaker : public TreeUpdater {
}
char const* Name() const override {
return "gpu_hist";
return "grow_gpu_hist";
}
private:

8
src/tree/updater_histmaker.cc
View File

@@ -635,7 +635,7 @@ class CQHistMaker: public HistMaker {
class GlobalProposalHistMaker: public CQHistMaker {
public:
char const* Name() const override {
return "grow_global_histmaker";
return "grow_histmaker";
}
protected:
@@ -740,12 +740,6 @@ XGBOOST_REGISTER_TREE_UPDATER(LocalHistMaker, "grow_local_histmaker")
return new CQHistMaker();
});
XGBOOST_REGISTER_TREE_UPDATER(GlobalHistMaker, "grow_global_histmaker")
.describe("Tree constructor that uses approximate global proposal of histogram construction.")
.set_body([]() {
return new GlobalProposalHistMaker();
});
XGBOOST_REGISTER_TREE_UPDATER(HistMaker, "grow_histmaker")
.describe("Tree constructor that uses approximate global of histogram construction.")
.set_body([]() {