Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Eliminate use of System.out + proper error logging (#3572)

Browse Source
This commit is contained in:
Matthew Tovbin 2018-08-09 10:06:17 -07:00 committed by Philip Hyunsu Cho
parent bbb771f32e
commit bad76048d1
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
jvm-packages/xgboost4j/src/main/java/ml/dmlc/xgboost4j/java/Booster.java
View File

@ -531,13 +531,11 @@ public class Booster implements Serializable, KryoSerializable {
try { try {
byte[] serObj = this.toByteArray(); byte[] serObj = this.toByteArray();
int serObjSize = serObj.length; int serObjSize = serObj.length;
System.out.println("==== serialized obj size " + serObjSize);
output.writeInt(serObjSize); output.writeInt(serObjSize);
output.writeInt(version); output.writeInt(version);
output.write(serObj); output.write(serObj);
} catch (XGBoostError ex) { } catch (XGBoostError ex) {
ex.printStackTrace(); logger.error(ex.getMessage(), ex);
logger.error(ex.getMessage());
} }
} }
@ -547,13 +545,11 @@ public class Booster implements Serializable, KryoSerializable {
this.init(null); this.init(null);
int serObjSize = input.readInt(); int serObjSize = input.readInt();
this.version = input.readInt(); this.version = input.readInt();
System.out.println("==== the size of the object: " + serObjSize);
byte[] bytes = new byte[serObjSize]; byte[] bytes = new byte[serObjSize];
input.readBytes(bytes); input.readBytes(bytes);
XGBoostJNI.checkCall(XGBoostJNI.XGBoosterLoadModelFromBuffer(this.handle, bytes)); XGBoostJNI.checkCall(XGBoostJNI.XGBoosterLoadModelFromBuffer(this.handle, bytes));
} catch (XGBoostError ex) { } catch (XGBoostError ex) {
ex.printStackTrace(); logger.error(ex.getMessage(), ex);
logger.error(ex.getMessage());
} }
} }
} }