Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix ring passing

Browse Source
This commit is contained in:
tqchen 2014-12-07 20:25:42 -08:00
parent 8d570b54c7
commit b38fa40fa6
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/allreduce_robust.cc
View File

@ -45,6 +45,9 @@ void AllreduceRobust::SetParam(const char *name, const char *val) {
if (!strcmp(name, "result_replicate")) { if (!strcmp(name, "result_replicate")) {
result_buffer_round = std::max(world_size / atoi(val), 1); result_buffer_round = std::max(world_size / atoi(val), 1);
} }
if (!strcmp(name, "num_local_replica")) {
num_local_replica = atoi(val);
}
} }
/*! /*!
* \brief perform in-place allreduce, on sendrecvbuf * \brief perform in-place allreduce, on sendrecvbuf
@ -1010,9 +1013,9 @@ AllreduceRobust::RingPassing(void *sendrecvbuf_,
LinkRecord *read_link, LinkRecord *read_link,
LinkRecord *write_link) { LinkRecord *write_link) {
if (read_link == NULL || write_link == NULL || read_end == 0) return kSuccess; if (read_link == NULL || write_link == NULL || read_end == 0) return kSuccess;
utils::Assert(read_end <= write_end, "boundary check"); utils::Assert(write_end <= read_end, "RingPassing: boundary check1");
utils::Assert(read_ptr <= read_end, "boundary check"); utils::Assert(read_ptr <= read_end, "RingPassing: boundary check2");
utils::Assert(write_ptr <= write_end, "boundary check"); utils::Assert(write_ptr <= write_end, "RingPassing: boundary check3");
// take reference // take reference
LinkRecord &prev = *read_link, &next = *write_link; LinkRecord &prev = *read_link, &next = *write_link;
// send recv buffer // send recv buffer