Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update dmlc-core submodule and conform to new API (#6431)

Browse Source 
* Update dmlc-core submodule and conform to new API

* Remove unsupported parameter from method signature

* Update dmlc-core submodule and conform to new API

* Update dmlc-core

Co-authored-by: Hyunsu Cho <chohyu01@cs.washington.edu>
This commit is contained in:
TP Boudreau 2021-01-06 00:12:22 +00:00 committed by GitHub
parent 60cfd14349
commit b2246ae7ef
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.gitmodules vendored
View File

@ -1,6 +1,7 @@
[submodule "dmlc-core"] [submodule "dmlc-core"]
path = dmlc-core path = dmlc-core
url = https://github.com/dmlc/dmlc-core url = https://github.com/dmlc/dmlc-core
branch = main
[submodule "cub"] [submodule "cub"]
path = cub path = cub
url = https://github.com/NVlabs/cub url = https://github.com/NVlabs/cub

2
dmlc-core

@ -1 +1 @@
Subproject commit 5df8305fe699d3b503d10c60a231ab0223142407 Subproject commit f0ff3146705e27ac2b1e6081fa0983a8a6fda72d

7
include/xgboost/parameter.h
View File

@ -87,14 +87,11 @@ struct XGBoostParameter : public dmlc::Parameter<Type> {
public: public:
template <typename Container> template <typename Container>
Args UpdateAllowUnknown(Container const& kwargs, bool* out_changed = nullptr) { Args UpdateAllowUnknown(Container const& kwargs) {
if (initialised_) { if (initialised_) {
return dmlc::Parameter<Type>::UpdateAllowUnknown(kwargs, out_changed); return dmlc::Parameter<Type>::UpdateAllowUnknown(kwargs);
} else { } else {
auto unknown = dmlc::Parameter<Type>::InitAllowUnknown(kwargs); auto unknown = dmlc::Parameter<Type>::InitAllowUnknown(kwargs);
if (out_changed) {
*out_changed = true;
}
initialised_ = true; initialised_ = true;
return unknown; return unknown;
} }