Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid caching allocator for large allocations. (#10582)

Browse Source
This commit is contained in:
Jiaming Yuan
2024-07-23 03:48:03 +08:00
committed by GitHub
parent b2cae34a8e
commit a19bbc9be5
7 changed files with 80 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/cpp/tree/gpu_hist/test_histogram.cu
View File

@@ -66,7 +66,8 @@ void TestDeterministicHistogram(bool is_dense, int shm_size, bool force_global)
for (auto const& batch : matrix->GetBatches<EllpackPage>(&ctx, batch_param)) {
auto* page = batch.Impl();
tree::RowPartitioner row_partitioner{&ctx, kRows, page->base_rowid};
tree::RowPartitioner row_partitioner;
row_partitioner.Reset(&ctx, kRows, page->base_rowid);
auto ridx = row_partitioner.GetRows(0);
bst_bin_t num_bins = kBins * kCols;
@@ -171,7 +172,8 @@ void TestGPUHistogramCategorical(size_t num_categories) {
auto cat_m = GetDMatrixFromData(x, kRows, 1);
cat_m->Info().feature_types.HostVector().push_back(FeatureType::kCategorical);
auto batch_param = BatchParam{kBins, tree::TrainParam::DftSparseThreshold()};
tree::RowPartitioner row_partitioner{&ctx, kRows, 0};
tree::RowPartitioner row_partitioner;
row_partitioner.Reset(&ctx, kRows, 0);
auto ridx = row_partitioner.GetRows(0);
dh::device_vector<GradientPairInt64> cat_hist(num_categories);
auto gpair = GenerateRandomGradients(kRows, 0, 2);
@@ -343,8 +345,8 @@ class HistogramExternalMemoryTest : public ::testing::TestWithParam<std::tuple<f
cuts = std::make_shared<common::HistogramCuts>(impl->Cuts());
}
partitioners.emplace_back(
std::make_unique<RowPartitioner>(&ctx, impl->Size(), impl->base_rowid));
partitioners.emplace_back(std::make_unique<RowPartitioner>());
partitioners.back()->Reset(&ctx, impl->Size(), impl->base_rowid);
auto ridx = partitioners.at(k)->GetRows(0);
auto d_histogram = dh::ToSpan(multi_hist);
@@ -362,7 +364,9 @@ class HistogramExternalMemoryTest : public ::testing::TestWithParam<std::tuple<f
/**
* Single page.
*/
RowPartitioner partitioner{&ctx, p_fmat->Info().num_row_, 0};
RowPartitioner partitioner;
partitioner.Reset(&ctx, p_fmat->Info().num_row_, 0);
SparsePage concat;
std::vector<float> hess(p_fmat->Info().num_row_, 1.0f);
for (auto const& page : p_fmat->GetBatches<SparsePage>()) {

3
tests/cpp/tree/gpu_hist/test_row_partitioner.cu
View File

@@ -16,7 +16,8 @@ namespace xgboost::tree {
void TestUpdatePositionBatch() {
const int kNumRows = 10;
auto ctx = MakeCUDACtx(0);
RowPartitioner rp{&ctx, kNumRows, 0};
RowPartitioner rp;
rp.Reset(&ctx, kNumRows, 0);
auto rows = rp.GetRowsHost(0);
EXPECT_EQ(rows.size(), kNumRows);
for (auto i = 0ull; i < kNumRows; i++) {