Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[R] avoid leaking exception objects (#9916)

Browse Source
This commit is contained in:
david-cortes 2023-12-26 13:29:55 +01:00 committed by GitHub
parent 52620fdb34
commit a197899161
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
R-package/src/xgboost_R.cc
View File

@ -161,15 +161,13 @@ object, need to be destructed before triggering the R error.
In order to preserve the error message, it gets copied to a temporary In order to preserve the error message, it gets copied to a temporary
buffer, and the R error section is reached through a 'goto' statement buffer, and the R error section is reached through a 'goto' statement
that bypasses usual function control flow. */ that bypasses usual function control flow. */
char cpp_ex_msg[256]; char cpp_ex_msg[512];
/*! /*!
* \brief macro to annotate end of api * \brief macro to annotate end of api
*/ */
#define R_API_END() \ #define R_API_END() \
} catch(dmlc::Error& e) { \
Rf_error("%s", e.what()); \
} catch(std::exception &e) { \ } catch(std::exception &e) { \
std::strncpy(cpp_ex_msg, e.what(), 256); \ std::strncpy(cpp_ex_msg, e.what(), 512); \
goto throw_cpp_ex_as_R_err; \ goto throw_cpp_ex_as_R_err; \
} \ } \
if (false) { \ if (false) { \