Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix monotone constraint with tuple input. (#7891) (#8159)

Browse Source
This commit is contained in:
Jiaming Yuan 2022-08-12 22:05:53 +08:00 committed by GitHub
parent 140c377a96
commit 9c653378e2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
python-package/xgboost/core.py
View File

@ -1403,10 +1403,12 @@ class Booster:
self.set_param(params_processed or {}) self.set_param(params_processed or {})
def _transform_monotone_constrains( def _transform_monotone_constrains(
self, value: Union[Dict[str, int], str] self, value: Union[Dict[str, int], str, Tuple[int, ...]]
) -> Union[Tuple[int, ...], str]: ) -> Union[Tuple[int, ...], str]:
if isinstance(value, str): if isinstance(value, str):
return value return value
if isinstance(value, tuple):
return value
constrained_features = set(value.keys()) constrained_features = set(value.keys())
feature_names = self.feature_names or [] feature_names = self.feature_names or []

5
tests/python/test_monotone_constraints.py
View File

@ -93,6 +93,11 @@ class TestMonotoneConstraints:
constrained = xgb.train(params_for_constrained, training_dset) constrained = xgb.train(params_for_constrained, training_dset)
assert is_correctly_constrained(constrained) assert is_correctly_constrained(constrained)
def test_monotone_constraints_tuple(self) -> None:
params_for_constrained = {"monotone_constraints": (1, -1)}
constrained = xgb.train(params_for_constrained, training_dset)
assert is_correctly_constrained(constrained)
@pytest.mark.parametrize('format', [dict, list]) @pytest.mark.parametrize('format', [dict, list])
def test_monotone_constraints_feature_names(self, format): def test_monotone_constraints_feature_names(self, format):