From 9b917cda4ff61f0512cdba1c53bc8e55258a5d4a Mon Sep 17 00:00:00 2001 From: Rong Ou Date: Mon, 11 Feb 2019 21:47:30 -0800 Subject: [PATCH] [jvm-packages] fix simple logic error :) (#4128) @CodingCat --- .../ml/dmlc/xgboost4j/scala/spark/params/GeneralParams.scala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/params/GeneralParams.scala b/jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/params/GeneralParams.scala index 6d9c9b474..854298d1e 100644 --- a/jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/params/GeneralParams.scala +++ b/jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/params/GeneralParams.scala @@ -231,8 +231,8 @@ private[spark] trait ParamMapFuncs extends Params { def XGBoostToMLlibParams(xgboostParams: Map[String, Any]): Unit = { for ((paramName, paramValue) <- xgboostParams) { if ((paramName == "booster" && paramValue != "gbtree") || - (paramName == "updater" && (paramValue != "grow_histmaker,prune" || - paramValue != "hist"))) { + (paramName == "updater" && paramValue != "grow_histmaker,prune" && + paramValue != "hist")) { throw new IllegalArgumentException(s"you specified $paramName as $paramValue," + s" XGBoost-Spark only supports gbtree as booster type" + " and grow_histmaker,prune or hist as the updater type")