From 94e655329f07df2f2e662e1967565ae79cf93ef5 Mon Sep 17 00:00:00 2001 From: Vadim Khotilovich Date: Tue, 6 Feb 2018 02:00:34 -0600 Subject: [PATCH] Replacing cout with LOG (#3076) * change cout to LOG * lint fix --- src/common/quantile.h | 15 +++++++-------- src/common/timer.h | 8 ++++---- 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/src/common/quantile.h b/src/common/quantile.h index 98f7f732b..c79eca5e3 100644 --- a/src/common/quantile.h +++ b/src/common/quantile.h @@ -281,10 +281,10 @@ struct WQSummary { // helper function to print the current content of sketch inline void Print() const { for (size_t i = 0; i < this->size; ++i) { - LOG(INFO) << "[" << i << "] rmin=" << data[i].rmin - << ", rmax=" << data[i].rmax - << ", wmin=" << data[i].wmin - << ", v=" << data[i].value; + LOG(CONSOLE) << "[" << i << "] rmin=" << data[i].rmin + << ", rmax=" << data[i].rmax + << ", wmin=" << data[i].wmin + << ", v=" << data[i].value; } } // try to fix rounding error @@ -321,7 +321,7 @@ struct WQSummary { for (size_t i = 0; i < this->size; ++i) { if (data[i].rmin + data[i].wmin > data[i].rmax + tol || data[i].rmin < -1e-6f || data[i].rmax < -1e-6f) { - LOG(INFO) << "----------check not pass----------"; + LOG(INFO) << "---------- WQSummary::Check did not pass ----------"; this->Print(); return false; } @@ -503,9 +503,8 @@ struct GKSummary { /*! \brief used for debug purpose, print the summary */ inline void Print() const { for (size_t i = 0; i < size; ++i) { - std::cout << "x=" << data[i].value << "\t" - << "[" << data[i].rmin << "," << data[i].rmax << "]" - << std::endl; + LOG(CONSOLE) << "x=" << data[i].value << "\t" + << "[" << data[i].rmin << "," << data[i].rmax << "]"; } } /*! diff --git a/src/common/timer.h b/src/common/timer.h index cbff04cc1..418119379 100644 --- a/src/common/timer.h +++ b/src/common/timer.h @@ -27,7 +27,9 @@ struct Timer { void Stop() { elapsed += ClockT::now() - start; } double ElapsedSeconds() const { return SecondsT(elapsed).count(); } void PrintElapsed(std::string label) { - printf("%s:\t %fs\n", label.c_str(), SecondsT(elapsed).count()); + char buffer[255]; + snprintf(buffer, sizeof(buffer), "%s:\t %fs", label.c_str(), SecondsT(elapsed).count()); + LOG(CONSOLE) << buffer; Reset(); } }; @@ -50,9 +52,7 @@ struct Monitor { ~Monitor() { if (!debug_verbose) return; - std::cout << "========\n"; - std::cout << "Monitor: " << label << "\n"; - std::cout << "========\n"; + LOG(CONSOLE) << "======== Monitor: " << label << " ========"; for (auto &kv : timer_map) { kv.second.PrintElapsed(kv.first); }