Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Extract string view. (#7416)

Browse Source 
* Add equality operators.
* Return a view in substr.
* Add proper iterator types.
This commit is contained in:
Jiaming Yuan
2021-11-12 18:22:30 +08:00
committed by GitHub
parent ca6f980932
commit 937fa282b5
7 changed files with 130 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
tests/cpp/common/test_json.cc
View File

@@ -457,10 +457,10 @@ TEST(Json, Invalid) {
bool has_thrown = false;
try {
Json load{Json::Load(StringView(str.c_str(), str.size()))};
} catch (dmlc::Error const &e) {
} catch (dmlc::Error const& e) {
std::string msg = e.what();
ASSERT_TRUE(msg.find("EOF") != std::string::npos
|| msg.find("255") != std::string::npos); // EOF is printed as 255 on s390x
// EOF is printed as 255 on s390x
ASSERT_TRUE(msg.find("EOF") != std::string::npos || msg.find("255") != std::string::npos);
has_thrown = true;
};
ASSERT_TRUE(has_thrown);
@@ -580,14 +580,4 @@ TEST(Json, DISABLED_RoundTripExhaustive) {
test(static_cast<uint32_t>(i));
}
}
TEST(StringView, Basic) {
StringView str{"This is a string."};
std::stringstream ss;
ss << str;
std::string res = ss.str();
ASSERT_EQ(str.size(), res.size());
ASSERT_TRUE(std::equal(res.cbegin(), res.cend(), str.cbegin()));
}
} // namespace xgboost

28
tests/cpp/common/test_string_view.cc Normal file
View File

@@ -0,0 +1,28 @@
/*!
* Copyright (c) by XGBoost Contributors 2021
*/
#include <gtest/gtest.h>
#include <xgboost/string_view.h>
#include <string_view>
namespace xgboost {
TEST(StringView, Basic) {
StringView str{"This is a string."};
std::stringstream ss;
ss << str;
std::string res = ss.str();
ASSERT_EQ(str.size(), res.size());
ASSERT_TRUE(std::equal(res.cbegin(), res.cend(), str.cbegin()));
auto substr = str.substr(5, 2);
ASSERT_EQ(substr.size(), 2);
ASSERT_EQ(StringView{"is"}.size(), 2);
ASSERT_TRUE(substr == "is");
ASSERT_FALSE(substr != "is");
ASSERT_FALSE(substr == "foobar");
ASSERT_FALSE(substr == "i");
ASSERT_TRUE(std::equal(substr.crbegin(), substr.crend(), StringView{"si"}.cbegin()));
}
} // namespace xgboost