Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Minor refactor of split evaluation in gpu_hist (#3889)

Browse Source 
* Refactor evaluate split into shard

* Use span in evaluate split

* Update google tests
This commit is contained in:
Rory Mitchell
2018-11-14 00:11:20 +13:00
committed by GitHub
parent daf77ca7b7
commit 926eb651fe
3 changed files with 129 additions and 193 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/cpp/tree/test_gpu_hist.cu
View File

@@ -168,13 +168,13 @@ void TestBuildHist(GPUHistBuilderBase& builder) {
builder.Build(&shard, 0);
DeviceHistogram d_hist = shard.hist;
GradientPairSumT* d_histptr {d_hist.GetHistPtr(0)};
auto node_histogram = d_hist.GetNodeHistogram(0);
// d_hist.data stored in float, not gradient pair
thrust::host_vector<GradientPairSumT> h_result (d_hist.data.size()/2);
size_t data_size = sizeof(GradientPairSumT) / (
sizeof(GradientPairSumT) / sizeof(GradientPairSumT::ValueT));
data_size *= d_hist.data.size();
dh::safe_cuda(cudaMemcpy(h_result.data(), d_histptr, data_size,
dh::safe_cuda(cudaMemcpy(h_result.data(), node_histogram.data(), data_size,
cudaMemcpyDeviceToHost));
std::vector<GradientPairPrecise> solution = GetHostHistGpair();
@@ -293,12 +293,11 @@ TEST(GpuHist, EvaluateSplits) {
hist_maker.node_value_constraints_[0].lower_bound = -1.0;
hist_maker.node_value_constraints_[0].upper_bound = 1.0;
std::vector<DeviceSplitCandidate> res =
hist_maker.EvaluateSplits({0}, &tree);
DeviceSplitCandidate res =
hist_maker.EvaluateSplit(0, &tree);
ASSERT_EQ(res.size(), 1);
ASSERT_EQ(res[0].findex, 7);
ASSERT_NEAR(res[0].fvalue, 0.26, xgboost::kRtEps);
ASSERT_EQ(res.findex, 7);
ASSERT_NEAR(res.fvalue, 0.26, xgboost::kRtEps);
}
TEST(GpuHist, ApplySplit) {