diff --git a/Makefile b/Makefile index 9ad197ee5..ecaf15077 100644 --- a/Makefile +++ b/Makefile @@ -260,7 +260,8 @@ Rpack: clean_all cp ./LICENSE xgboost cat R-package/src/Makevars.in|sed '2s/.*/PKGROOT=./' | sed '3s/.*/ENABLE_STD_THREAD=0/' > xgboost/src/Makevars.in cp xgboost/src/Makevars.in xgboost/src/Makevars.win - sed -i -e 's/@OPENMP_CXXFLAGS@/$$\(SHLIB_OPENMP_CFLAGS\)/g' xgboost/src/Makevars.win + sed -i -e 's/@OPENMP_CXXFLAGS@/$$\(SHLIB_OPENMP_CXXFLAGS\)/g' xgboost/src/Makevars.win + sed -i -e 's/-pthread/$$\(SHLIB_PTHREAD_FLAGS\)/g' xgboost/src/Makevars.win bash R-package/remove_warning_suppression_pragma.sh rm xgboost/remove_warning_suppression_pragma.sh diff --git a/R-package/R/xgb.plot.deepness.R b/R-package/R/xgb.plot.deepness.R index bfbf61a89..87d632ace 100644 --- a/R-package/R/xgb.plot.deepness.R +++ b/R-package/R/xgb.plot.deepness.R @@ -27,7 +27,7 @@ #' a tree's median absolute leaf weight changes through the iterations. #' #' This function was inspired by the blog post -#' \url{http://aysent.github.io/2015/11/08/random-forest-leaf-visualization.html}. +#' \url{https://github.com/aysent/random-forest-leaf-visualization}. #' #' @return #' diff --git a/R-package/configure b/R-package/configure index 7db7190b5..6c14550c9 100755 --- a/R-package/configure +++ b/R-package/configure @@ -1667,12 +1667,12 @@ OPENMP_CXXFLAGS="" if test `uname -s` = "Linux" then - OPENMP_CXXFLAGS="\$(SHLIB_OPENMP_CFLAGS)" + OPENMP_CXXFLAGS="\$(SHLIB_OPENMP_CXXFLAGS)" fi if test `uname -s` = "Darwin" then - OPENMP_CXXFLAGS="\$(SHLIB_OPENMP_CFLAGS)" + OPENMP_CXXFLAGS="\$(SHLIB_OPENMP_CXXFLAGS)" ac_pkg_openmp=no { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether OpenMP will work in a package" >&5 $as_echo_n "checking whether OpenMP will work in a package... " >&6; } diff --git a/R-package/configure.ac b/R-package/configure.ac index d9b706ec4..a2a05d221 100644 --- a/R-package/configure.ac +++ b/R-package/configure.ac @@ -8,12 +8,12 @@ OPENMP_CXXFLAGS="" if test `uname -s` = "Linux" then - OPENMP_CXXFLAGS="\$(SHLIB_OPENMP_CFLAGS)" + OPENMP_CXXFLAGS="\$(SHLIB_OPENMP_CXXFLAGS)" fi if test `uname -s` = "Darwin" then - OPENMP_CXXFLAGS="\$(SHLIB_OPENMP_CFLAGS)" + OPENMP_CXXFLAGS="\$(SHLIB_OPENMP_CXXFLAGS)" ac_pkg_openmp=no AC_MSG_CHECKING([whether OpenMP will work in a package]) AC_LANG_CONFTEST( diff --git a/R-package/man/xgb.plot.deepness.Rd b/R-package/man/xgb.plot.deepness.Rd index d4b23c1bf..7d76f9f0a 100644 --- a/R-package/man/xgb.plot.deepness.Rd +++ b/R-package/man/xgb.plot.deepness.Rd @@ -50,7 +50,7 @@ per tree with respect to tree number are created. And \code{which="med.weight"} a tree's median absolute leaf weight changes through the iterations. This function was inspired by the blog post -\url{http://aysent.github.io/2015/11/08/random-forest-leaf-visualization.html}. +\url{https://github.com/aysent/random-forest-leaf-visualization}. } \examples{ diff --git a/R-package/src/Makevars.in b/R-package/src/Makevars.in index 728d6c519..076ad7208 100644 --- a/R-package/src/Makevars.in +++ b/R-package/src/Makevars.in @@ -17,8 +17,8 @@ endif $(foreach v, $(XGB_RFLAGS), $(warning $(v))) PKG_CPPFLAGS= -I$(PKGROOT)/include -I$(PKGROOT)/dmlc-core/include -I$(PKGROOT)/rabit/include -I$(PKGROOT) $(XGB_RFLAGS) -PKG_CXXFLAGS= @OPENMP_CXXFLAGS@ $(SHLIB_PTHREAD_FLAGS) -PKG_LIBS = @OPENMP_CXXFLAGS@ $(SHLIB_PTHREAD_FLAGS) +PKG_CXXFLAGS= @OPENMP_CXXFLAGS@ -pthread +PKG_LIBS = @OPENMP_CXXFLAGS@ -pthread OBJECTS= ./xgboost_R.o ./xgboost_custom.o ./xgboost_assert.o ./init.o\ $(PKGROOT)/amalgamation/xgboost-all0.o $(PKGROOT)/amalgamation/dmlc-minimum0.o\ $(PKGROOT)/rabit/src/engine_empty.o $(PKGROOT)/rabit/src/c_api.o diff --git a/R-package/src/Makevars.win b/R-package/src/Makevars.win index 195310d98..2e241164e 100644 --- a/R-package/src/Makevars.win +++ b/R-package/src/Makevars.win @@ -29,8 +29,8 @@ endif $(foreach v, $(XGB_RFLAGS), $(warning $(v))) PKG_CPPFLAGS= -I$(PKGROOT)/include -I$(PKGROOT)/dmlc-core/include -I$(PKGROOT)/rabit/include -I$(PKGROOT) $(XGB_RFLAGS) -PKG_CXXFLAGS= $(SHLIB_OPENMP_CFLAGS) $(SHLIB_PTHREAD_FLAGS) -PKG_LIBS = $(SHLIB_OPENMP_CFLAGS) $(SHLIB_PTHREAD_FLAGS) +PKG_CXXFLAGS= $(SHLIB_OPENMP_CXXFLAGS) $(SHLIB_PTHREAD_FLAGS) +PKG_LIBS = $(SHLIB_OPENMP_CXXFLAGS) $(SHLIB_PTHREAD_FLAGS) OBJECTS= ./xgboost_R.o ./xgboost_custom.o ./xgboost_assert.o ./init.o\ $(PKGROOT)/amalgamation/xgboost-all0.o $(PKGROOT)/amalgamation/dmlc-minimum0.o\ $(PKGROOT)/rabit/src/engine_empty.o $(PKGROOT)/rabit/src/c_api.o diff --git a/src/common/transform.h b/src/common/transform.h index ac5c91aeb..ce452814e 100644 --- a/src/common/transform.h +++ b/src/common/transform.h @@ -172,8 +172,8 @@ class Transform { /*! \brief Range object specifying parallel threads index range. */ Range range_; /*! \brief Whether resharding for vectors is required. */ - bool reshard_; GPUDistribution distribution_; + bool reshard_; }; public: