From 8083c30e7b7dadf4e19387d18573abe3b70ffe12 Mon Sep 17 00:00:00 2001 From: tqchen Date: Sat, 1 Aug 2015 09:18:34 -0700 Subject: [PATCH] quick fix of solaris problem in cranc check --- CHANGES.md | 18 ++++++++++-------- R-package/README.md | 4 ++-- R-package/src/xgboost_R.cpp | 2 +- 3 files changed, 13 insertions(+), 11 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index 0be001744..d9c8786c0 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,18 +1,18 @@ Change Log -===== +========== xgboost-0.1 -===== +=========== * Initial release xgboost-0.2x -===== +============ * Python module * Weighted samples instances * Initial version of pairwise rank xgboost-0.3 -===== +=========== * Faster tree construction module - Allows subsample columns during tree construction via ```bst:col_samplebytree=ratio``` * Support for boosting from initial predictions @@ -22,7 +22,7 @@ xgboost-0.3 * Add R module xgboost-0.4 -===== +=========== * Distributed version of xgboost that runs on YARN, scales to billions of examples * Direct save/load data and model from/to S3 and HDFS * Feature importance visualization in R module, by Michael Benesty @@ -35,9 +35,11 @@ xgboost-0.4 * sklearn wrapper is supported in python module * Experimental External memory version -on going version -===== +on going at master +================== +* Fix List + - Fixed possible problem of poisson regression for R. * Python module now throw exception instead of crash terminal when a parameter error happens. * Java api is ready for use * Added more test cases and continuous integration to make each build more robust -* Improvements in sklearn compatible module +* Improvements in sklearn compatible module \ No newline at end of file diff --git a/R-package/README.md b/R-package/README.md index 81dabb31c..96113c391 100644 --- a/R-package/README.md +++ b/R-package/README.md @@ -24,10 +24,10 @@ If you face an issue installing the package using ```devtools::install_github`` ``` devtools::install_github('dmlc/xgboost',subdir='R-package') Downloading github repo dmlc/xgboost@master -Error in function (type, msg, asError = TRUE) : +Error in function (type, msg, asError = TRUE) : Peer certificate cannot be authenticated with given CA certificates ``` -To get around this you can build the package locally as mentioned [here](https://github.com/dmlc/xgboost/issues/347) - +To get around this you can build the package locally as mentioned [here](https://github.com/dmlc/xgboost/issues/347) - ``` 1. Clone the current repository and set your workspace to xgboost/R-package/ 2. Run R CMD INSTALL --build . in terminal to get the tarball. diff --git a/R-package/src/xgboost_R.cpp b/R-package/src/xgboost_R.cpp index a8084b206..37a30c797 100644 --- a/R-package/src/xgboost_R.cpp +++ b/R-package/src/xgboost_R.cpp @@ -32,7 +32,7 @@ extern "C" { bool CheckNAN(double v) { return ISNAN(v); } -bool LogGamma(double v) { +double LogGamma(double v) { return lgammafn(v); } } // namespace utils