Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix repeated split and 0 cover nodes (#5010)

Browse Source
This commit is contained in:
Christopher Cowden 2019-11-06 00:57:22 -06:00 committed by Jiaming Yuan
parent b29b8c2f34
commit 807a244517
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/tree/updater_colmaker.cc
View File

@ -409,14 +409,26 @@ class ColMaker: public TreeUpdater {
loss_chg = static_cast<bst_float>( loss_chg = static_cast<bst_float>(
spliteval_->ComputeSplitScore(nid, fid, c, e.stats) - spliteval_->ComputeSplitScore(nid, fid, c, e.stats) -
snode_[nid].root_gain); snode_[nid].root_gain);
e.best.Update(loss_chg, fid, (fvalue + e.last_fvalue) * 0.5f, bst_float proposed_split = (fvalue + e.last_fvalue) * 0.5f;
if ( proposed_split == fvalue ) {
e.best.Update(loss_chg, fid, e.last_fvalue,
d_step == -1, c, e.stats); d_step == -1, c, e.stats);
} else {
e.best.Update(loss_chg, fid, proposed_split,
d_step == -1, c, e.stats);
}
} else { } else {
loss_chg = static_cast<bst_float>( loss_chg = static_cast<bst_float>(
spliteval_->ComputeSplitScore(nid, fid, e.stats, c) - spliteval_->ComputeSplitScore(nid, fid, e.stats, c) -
snode_[nid].root_gain); snode_[nid].root_gain);
e.best.Update(loss_chg, fid, (fvalue + e.last_fvalue) * 0.5f, bst_float proposed_split = (fvalue + e.last_fvalue) * 0.5f;
if ( proposed_split == fvalue ) {
e.best.Update(loss_chg, fid, e.last_fvalue,
d_step == -1, e.stats, c); d_step == -1, e.stats, c);
} else {
e.best.Update(loss_chg, fid, proposed_split,
d_step == -1, e.stats, c);
}
} }
} }
} }