Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[R] Use R's error stream for printing warnings (#9965)

Browse Source
This commit is contained in:
david-cortes 2024-01-08 20:43:21 +01:00 committed by GitHub
parent b3eb5d0945
commit 7ff6d44efa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
R-package/src/xgboost_custom.cc
View File

@ -17,7 +17,11 @@ namespace xgboost {
ConsoleLogger::~ConsoleLogger() { ConsoleLogger::~ConsoleLogger() {
if (cur_verbosity_ == LogVerbosity::kIgnore || if (cur_verbosity_ == LogVerbosity::kIgnore ||
cur_verbosity_ <= GlobalVerbosity()) { cur_verbosity_ <= GlobalVerbosity()) {
dmlc::CustomLogMessage::Log(log_stream_.str()); if (cur_verbosity_ == LogVerbosity::kWarning) {
REprintf("%s\n", log_stream_.str().c_str());
} else {
dmlc::CustomLogMessage::Log(log_stream_.str());
}
} }
} }
TrackerLogger::~TrackerLogger() { TrackerLogger::~TrackerLogger() {

3
R-package/tests/testthat/test_basic.R
View File

@ -83,7 +83,8 @@ test_that("parameter validation works", {
bar = "foo" bar = "foo"
) )
output <- capture.output( output <- capture.output(
xgb.train(params = params, data = dtrain, nrounds = nrounds) xgb.train(params = params, data = dtrain, nrounds = nrounds),
type = "message"
) )
print(output) print(output)
} }