Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Port patches from 1.0.0 branch (#5336)

Browse Source 
* Remove f-string, since it's not supported by Python 3.5 (#5330)

* Remove f-string, since it's not supported by Python 3.5

* Add Python 3.5 to CI, to ensure compatibility

* Remove duplicated matplotlib

* Show deprecation notice for Python 3.5

* Fix lint

* Fix lint

* Fix a unit test that mistook MINOR ver for PATCH ver

* Enforce only major version in JSON model schema

* Bump version to 1.1.0-SNAPSHOT
This commit is contained in:
Philip Hyunsu Cho
2020-02-21 13:13:21 -08:00
committed by GitHub
parent 8aa8ef1031
commit 7ac7e8778f
16 changed files with 81 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/cpp/common/test_version.cc
View File

@@ -54,7 +54,7 @@ TEST(Version, Basic) {
ptr = 0;
v = std::stoi(str, &ptr);
ASSERT_EQ(v, XGBOOST_VER_MINOR) << "patch: " << v;;
ASSERT_EQ(v, XGBOOST_VER_PATCH) << "patch: " << v;;
str = str.substr(ptr);
ASSERT_EQ(str.size(), 0);