Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix incorrect minimum value in quantile generation (#3167)

Browse Source
This commit is contained in:
Rory Mitchell 2018-03-15 04:21:18 +13:00 committed by Philip Hyunsu Cho
parent 706be4e5d4
commit 7a81c87dfa
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/common/hist_util.cc
View File

@ -75,7 +75,7 @@ void HistCutMatrix::Init(DMatrix* p_fmat, uint32_t max_num_bins) {
a.Reserve(max_num_bins); a.Reserve(max_num_bins);
a.SetPrune(summary_array[fid], max_num_bins); a.SetPrune(summary_array[fid], max_num_bins);
const bst_float mval = a.data[0].value; const bst_float mval = a.data[0].value;
this->min_val[fid] = mval - fabs(mval); this->min_val[fid] = mval - (fabs(mval) + 1e-5);
if (a.size > 1 && a.size <= 16) { if (a.size > 1 && a.size <= 16) {
/* specialized code categorial / ordinal data -- use midpoints */ /* specialized code categorial / ordinal data -- use midpoints */
for (size_t i = 1; i < a.size; ++i) { for (size_t i = 1; i < a.size; ++i) {
@ -96,9 +96,10 @@ void HistCutMatrix::Init(DMatrix* p_fmat, uint32_t max_num_bins) {
if (a.size != 0) { if (a.size != 0) {
bst_float cpt = a.data[a.size - 1].value; bst_float cpt = a.data[a.size - 1].value;
// this must be bigger than last value in a scale // this must be bigger than last value in a scale
bst_float last = cpt + fabs(cpt); bst_float last = cpt + (fabs(cpt) + 1e-5);
cut.push_back(last); cut.push_back(last);
} }
row_ptr.push_back(static_cast<bst_uint>(cut.size())); row_ptr.push_back(static_cast<bst_uint>(cut.size()));
} }
} }