Serialize expand entry for allgather. (#9702)

This commit is contained in:
Jiaming Yuan
2023-10-24 14:33:28 +08:00
committed by GitHub
parent ee8b29c843
commit 7a02facc9d
14 changed files with 336 additions and 76 deletions

View File

@@ -0,0 +1,28 @@
/**
* Copyright 2023, XGBoost Contributors
*/
#include <gtest/gtest.h>
#include <xgboost/json.h>
#include <xgboost/tree_model.h> // for RegTree
#include "../../../../src/tree/gpu_hist/expand_entry.cuh"
namespace xgboost::tree {
TEST(ExpandEntry, IOGPU) {
DeviceSplitCandidate split;
GPUExpandEntry entry{RegTree::kRoot, 0, split, 3.0, 1.0, 2.0};
Json je{Object{}};
entry.Save(&je);
GPUExpandEntry loaded;
loaded.Load(je);
ASSERT_EQ(entry.base_weight, loaded.base_weight);
ASSERT_EQ(entry.left_weight, loaded.left_weight);
ASSERT_EQ(entry.right_weight, loaded.right_weight);
ASSERT_EQ(entry.GetDepth(), loaded.GetDepth());
ASSERT_EQ(entry.GetLossChange(), loaded.GetLossChange());
}
} // namespace xgboost::tree

View File

@@ -0,0 +1,57 @@
/**
* Copyright 2023, XGBoost Contributors
*/
#include <gtest/gtest.h>
#include <xgboost/json.h> // for Json
#include <xgboost/tree_model.h> // for RegTree
#include "../../../../src/tree/hist/expand_entry.h"
namespace xgboost::tree {
TEST(ExpandEntry, IO) {
CPUExpandEntry entry{RegTree::kRoot, 0};
entry.split.Update(1.0, 1, /*new_split_value=*/0.3, true, true, GradStats{1.0, 1.0},
GradStats{2.0, 2.0});
bst_bin_t n_bins_feature = 256;
auto n = common::CatBitField::ComputeStorageSize(n_bins_feature);
entry.split.cat_bits = decltype(entry.split.cat_bits)(n, 0);
common::CatBitField cat_bits{entry.split.cat_bits};
cat_bits.Set(n_bins_feature / 2);
Json je{Object{}};
entry.Save(&je);
CPUExpandEntry loaded;
loaded.Load(je);
ASSERT_EQ(loaded.split.is_cat, entry.split.is_cat);
ASSERT_EQ(loaded.split.cat_bits, entry.split.cat_bits);
ASSERT_EQ(loaded.split.left_sum.GetGrad(), entry.split.left_sum.GetGrad());
ASSERT_EQ(loaded.split.right_sum.GetHess(), entry.split.right_sum.GetHess());
}
TEST(ExpandEntry, IOMulti) {
MultiExpandEntry entry{RegTree::kRoot, 0};
auto left_sum = std::vector<GradientPairPrecise>{{1.0, 1.0}, {1.0, 1.0}};
auto right_sum = std::vector<GradientPairPrecise>{{2.0, 2.0}, {2.0, 2.0}};
entry.split.Update(1.0, 1, /*new_split_value=*/0.3, true, true,
linalg::MakeVec(left_sum.data(), left_sum.size()),
linalg::MakeVec(right_sum.data(), right_sum.size()));
bst_bin_t n_bins_feature = 256;
auto n = common::CatBitField::ComputeStorageSize(n_bins_feature);
entry.split.cat_bits = decltype(entry.split.cat_bits)(n, 0);
common::CatBitField cat_bits{entry.split.cat_bits};
cat_bits.Set(n_bins_feature / 2);
Json je{Object{}};
entry.Save(&je);
MultiExpandEntry loaded;
loaded.Load(je);
ASSERT_EQ(loaded.split.is_cat, entry.split.is_cat);
ASSERT_EQ(loaded.split.cat_bits, entry.split.cat_bits);
ASSERT_EQ(loaded.split.left_sum, entry.split.left_sum);
ASSERT_EQ(loaded.split.right_sum, entry.split.right_sum);
}
} // namespace xgboost::tree