Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "[jvm-packages] Add XGBOOST_RABIT_TRACKER_IP_FOR_TEST to set rabit tracker IP. (#6869)" (#6886)

Browse Source 
This reverts commit 2828da3c4c951baa45d1bb6f85c7b3a6657cd607.
This commit is contained in:
Jiaming Yuan 2021-04-22 02:20:10 +08:00 committed by GitHub
parent c8cc3eacc9
commit 74b41637de
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/main.yml vendored
View File

@ -210,8 +210,6 @@ jobs:
if: matrix.os == 'ubuntu-latest' # Distributed training doesn't work on Windows if: matrix.os == 'ubuntu-latest' # Distributed training doesn't work on Windows
env: env:
RABIT_MOCK: ON RABIT_MOCK: ON
SPARK_LOCAL_IP: 127.0.0.1
XGBOOST_RABIT_TRACKER_IP_FOR_TEST: 127.0.0.1
lint: lint:
runs-on: ubuntu-latest runs-on: ubuntu-latest

8
doc/jvm/xgboost4j_spark_tutorial.rst
View File

@ -586,11 +586,3 @@ An equivalent way is to pass in parameters in XGBoostClassifier's constructor:
setLabelCol("classIndex") setLabelCol("classIndex")
If the training failed during these 100 rounds, the next run of training would start by reading the latest checkpoint file in ``/checkpoints_path`` and start from the iteration when the checkpoint was built until to next failure or the specified 100 rounds. If the training failed during these 100 rounds, the next run of training would start by reading the latest checkpoint file in ``/checkpoints_path`` and start from the iteration when the checkpoint was built until to next failure or the specified 100 rounds.
Developer Notes
===============
There's an environment variable called ``XGBOOST_RABIT_TRACKER_IP_FOR_TEST`` used to
specify the tracker IP, which can be used in combination with ``SPARK_LOCAL_IP``. It's
only used for testing and is not maintained as a part of the interface.

4
jvm-packages/xgboost4j/src/main/java/ml/dmlc/xgboost4j/java/TrackerProperties.java
View File

@ -51,8 +51,6 @@ public class TrackerProperties {
} }
public String getHostIp(){ public String getHostIp(){
// mostly for testing return this.properties.getProperty(HOST_IP);
String hostIp = System.getenv("XGBOOST_RABIT_TRACKER_IP_FOR_TEST");
return hostIp != null ? hostIp : this.properties.getProperty(HOST_IP);
} }
} }