Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix external memory race in colmaker. (#4980)

Browse Source 
* Move `GetColDensity` out of omp parallel block.
This commit is contained in:
Jiaming Yuan
2019-10-25 04:11:13 -04:00
committed by GitHub
parent 96cd7ec2bb
commit 6ec7e300bd
9 changed files with 29 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/objective/rank_obj.cu
View File

@@ -34,7 +34,7 @@ DMLC_REGISTRY_FILE_TAG(rank_obj_gpu);
#endif // defined(XGBOOST_USE_CUDA)
struct LambdaRankParam : public XGBoostParameter<LambdaRankParam> {
int num_pairsample;
size_t num_pairsample;
float fix_list_weight;
// declare parameters
DMLC_DECLARE_PARAMETER(LambdaRankParam) {
@@ -337,7 +337,7 @@ class SortedLabelList {
// Launch a kernel that populates the segment information for the different groups
uint32_t *gsegs = group_segments_.data().get();
const unsigned *dgroups = dgroups_.data().get();
int ngroups = dgroups_.size();
size_t ngroups = dgroups_.size();
dh::LaunchN(device_id_, num_elems, nullptr, [=] __device__(unsigned idx){
// Find the group first
int group_idx = dh::UpperBound(dgroups, ngroups, idx);
@@ -405,10 +405,10 @@ class SortedLabelList {
float weight_normalization_factor) {
// Group info on device
const unsigned *dgroups = dgroups_.data().get();
int ngroups = dgroups_.size();
size_t ngroups = dgroups_.size();
uint32_t total_items = group_segments_.size();
int niter = param_.num_pairsample * total_items;
auto total_items = group_segments_.size();
size_t niter = param_.num_pairsample * total_items;
float fix_list_weight = param_.fix_list_weight;