Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix the row split recovery, add per iteration random number seed

Browse Source
This commit is contained in:
tqchen
2014-12-21 17:31:42 -08:00
parent eff5c6baa8
commit 677475529f
6 changed files with 34 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/tree/updater_basemaker-inl.hpp
View File

@@ -76,19 +76,15 @@ class BaseMaker: public IUpdater {
unsigned n = static_cast<unsigned>(p * findex.size());
random::Shuffle(findex);
findex.resize(n);
if (n != findex.size()) {
// sync the findex if it is subsample
std::string s_cache;
utils::MemoryBufferStream fc(&s_cache);
utils::IStream &fs = fc;
if (rabit::GetRank() == 0) {
fs.Write(findex);
rabit::Broadcast(&s_cache, 0);
} else {
rabit::Broadcast(&s_cache, 0);
fs.Read(&findex);
}
// sync the findex if it is subsample
std::string s_cache;
utils::MemoryBufferStream fc(&s_cache);
utils::IStream &fs = fc;
if (rabit::GetRank() == 0) {
fs.Write(findex);
}
rabit::Broadcast(&s_cache, 0);
fs.Read(&findex);
}
private:

11
src/tree/updater_sync-inl.hpp
View File

@@ -40,12 +40,11 @@ class TreeSyncher: public IUpdater {
for (size_t i = 0; i < trees.size(); ++i) {
trees[i]->SaveModel(fs);
}
rabit::Broadcast(&s_model, 0);
} else {
rabit::Broadcast(&s_model, 0);
for (size_t i = 0; i < trees.size(); ++i) {
trees[i]->LoadModel(fs);
}
}
fs.Seek(0);
rabit::Broadcast(&s_model, 0);
for (size_t i = 0; i < trees.size(); ++i) {
trees[i]->LoadModel(fs);
}
}
};