Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Compiler warnings (#6286)

Browse Source 
* Fix warnings for json.h

* Fix warnings for metric.h

* Fix warnings for updater_quantile_hist.cc.

* Fix warnings for updater_histmaker.cc.

Co-authored-by: Hyunsu Cho <chohyu01@cs.washington.edu>
This commit is contained in:
vcarpani
2020-10-28 21:46:15 +01:00
committed by GitHub
parent e8884c4637
commit 671971e12e
4 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/xgboost/json.h
View File

@@ -250,7 +250,7 @@ class JsonNull : public Value {
public:
JsonNull() : Value(ValueKind::kNull) {}
JsonNull(std::nullptr_t) : Value(ValueKind::kNull) {} // NOLINT
JsonNull(JsonNull&& that) : Value(ValueKind::kNull) {}
JsonNull(JsonNull&&) : Value(ValueKind::kNull) {}
void Save(JsonWriter* writer) override;

2
include/xgboost/metric.h
View File

@@ -34,7 +34,7 @@ class Metric : public Configurable {
* \param args arguments to the objective function.
*/
virtual void Configure(
const std::vector<std::pair<std::string, std::string> >& args) {}
const std::vector<std::pair<std::string, std::string> >&) {}
/*!
* \brief Load configuration from JSON object
* By default, metric has no internal configuration;