From 62830be29d3c761f0d7fd3fe085fb63be38bd9e0 Mon Sep 17 00:00:00 2001 From: chanis Date: Thu, 22 Sep 2016 01:12:19 +0800 Subject: [PATCH] [python-package] modify libpath.py and fix typos (#1594) * Update Makefile * Update Makefile * modify __init__.py * modified libpath.py and fixed typos --- python-package/xgboost/libpath.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/python-package/xgboost/libpath.py b/python-package/xgboost/libpath.py index 91c8dda92..9455eb1d1 100644 --- a/python-package/xgboost/libpath.py +++ b/python-package/xgboost/libpath.py @@ -12,7 +12,7 @@ class XGBoostLibraryNotFound(Exception): def find_lib_path(): - """Load find the path to xgboost dynamic library files. + """Find the path to xgboost dynamic library files. Returns ------- @@ -33,16 +33,15 @@ def find_lib_path(): dll_path.append(os.path.join(curr_path, '../../windows/Release/')) # hack for pip installation when copy all parent source directory here dll_path.append(os.path.join(curr_path, './windows/Release/')) - if os.name == 'nt': dll_path = [os.path.join(p, 'libxgboost.dll') for p in dll_path] else: dll_path = [os.path.join(p, 'libxgboost.so') for p in dll_path] lib_path = [p for p in dll_path if os.path.exists(p) and os.path.isfile(p)] # From github issues, most of installation errors come from machines w/o compilers - if len(lib_path) == 0 and not os.environ.get('XGBOOST_BUILD_DOC', False): + if not lib_path and not os.environ.get('XGBOOST_BUILD_DOC', False): raise XGBoostLibraryNotFound( - 'Cannot find XGBoost Libarary in the candidate path, ' + + 'Cannot find XGBoost Library in the candidate path, ' + 'did you install compilers and run build.sh in root path?\n' 'List of candidates:\n' + ('\n'.join(dll_path))) return lib_path