diff --git a/src/common/bitmap.h b/src/common/bitmap.h index d8d53c8db..ee102a680 100644 --- a/src/common/bitmap.h +++ b/src/common/bitmap.h @@ -47,7 +47,7 @@ struct BitMap { for (bst_omp_uint i = 0; i < nsize; ++i) { uint32_t res = 0; for (int k = 0; k < 32; ++k) { - int bit = vec[(i << 5) | k]; + uint32_t bit = vec[(i << 5) | k]; res |= (bit << k); } data[i] = res; diff --git a/src/learner.cc b/src/learner.cc index e3e3439bf..c0fa70384 100644 --- a/src/learner.cc +++ b/src/learner.cc @@ -31,13 +31,13 @@ const char* kMaxDeltaStepDefaultValue = "0.7"; inline bool IsFloat(const std::string& str) { std::stringstream ss(str); - float f; + float f{}; return !((ss >> std::noskipws >> f).rdstate() ^ std::ios_base::eofbit); } inline bool IsInt(const std::string& str) { std::stringstream ss(str); - int i; + int i{}; return !((ss >> std::noskipws >> i).rdstate() ^ std::ios_base::eofbit); } @@ -535,9 +535,6 @@ class LearnerImpl : public Learner { gbm_->PredictBatch(data, out_preds, ntree_limit); } - // return whether model is already initialized. - bool ModelInitialized() const { return configured_; } - void ConfigureObjective(LearnerTrainParam const& old, Args* p_args) { if (cfg_.find("num_class") != cfg_.cend() && cfg_.at("num_class") != "0") { cfg_["num_output_group"] = cfg_["num_class"]; diff --git a/src/objective/rank_obj.cc b/src/objective/rank_obj.cc index cb186a4f4..bc82d176f 100644 --- a/src/objective/rank_obj.cc +++ b/src/objective/rank_obj.cc @@ -146,10 +146,6 @@ class LambdaRankObj : public ObjFunction { inline static bool CmpPred(const ListEntry &a, const ListEntry &b) { return a.pred > b.pred; } - // comparator by label - inline static bool CmpLabel(const ListEntry &a, const ListEntry &b) { - return a.label > b.label; - } }; /*! \brief a pair in the lambda rank */ struct LambdaPair { diff --git a/src/tree/updater_colmaker.cc b/src/tree/updater_colmaker.cc index 709f956fb..64194c52b 100644 --- a/src/tree/updater_colmaker.cc +++ b/src/tree/updater_colmaker.cc @@ -817,9 +817,6 @@ class DistColMaker : public ColMaker { this->position_[ridx] = nid; } } - inline const int* GetLeafPosition() const { - return dmlc::BeginPtr(this->position_); - } protected: void SetNonDefaultPosition(const std::vector &qexpand, DMatrix *p_fmat, diff --git a/src/tree/updater_histmaker.cc b/src/tree/updater_histmaker.cc index 4b1110192..cce7bab11 100644 --- a/src/tree/updater_histmaker.cc +++ b/src/tree/updater_histmaker.cc @@ -96,16 +96,6 @@ class HistMaker: public BaseMaker { hset[tid].data.resize(cut.size(), GradStats()); } } - // aggregate all statistics to hset[0] - inline void Aggregate() { - bst_omp_uint nsize = static_cast(cut.size()); - #pragma omp parallel for schedule(static) - for (bst_omp_uint i = 0; i < nsize; ++i) { - for (size_t tid = 1; tid < hset.size(); ++tid) { - hset[0].data[i].Add(hset[tid].data[i]); - } - } - } /*! \brief clear the workspace */ inline void Clear() { cut.clear(); rptr.resize(1); rptr[0] = 0;