From 5ff210ed75fb8f37e14853482cd95c42a49c6c2f Mon Sep 17 00:00:00 2001 From: Jiaming Yuan Date: Wed, 20 Oct 2021 12:49:12 +0800 Subject: [PATCH] Small fix for the release doc and script. [skip ci] (#7332) Add Philip as co-maintainer of maven packages. --- dev/release-py-r.py | 10 +++++++--- doc/contrib/release.rst | 4 ++-- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/dev/release-py-r.py b/dev/release-py-r.py index 40f31c7bc..3a639feb5 100644 --- a/dev/release-py-r.py +++ b/dev/release-py-r.py @@ -105,7 +105,7 @@ Following steps should be done manually: def download_r_packages(release: str, rc: str, commit: str) -> None: - platforms = ["linux", "win64"] + platforms = ["win64", "linux"] dirname = "./r-packages" if not os.path.exists(dirname): os.mkdir(dirname) @@ -113,9 +113,13 @@ def download_r_packages(release: str, rc: str, commit: str) -> None: filenames = [] for plat in platforms: - url = f"{PREFIX}{release}/xgboost_r_gpu_linux_{commit}.tar.gz" + url = f"{PREFIX}{release}/xgboost_r_gpu_{plat}_{commit}.tar.gz" + + if not rc: + filename = f"xgboost_r_gpu_{plat}_{release}.tar.gz" + else: + filename = f"xgboost_r_gpu_{plat}_{release}-{rc}.tar.gz" - filename = f"xgboost_r_gpu_linux_{release}-{rc}.tar.gz" target = os.path.join(dirname, filename) retrieve(url=url, filename=target) filenames.append(target) diff --git a/doc/contrib/release.rst b/doc/contrib/release.rst index 4dac7718c..ae3f05c40 100644 --- a/doc/contrib/release.rst +++ b/doc/contrib/release.rst @@ -25,6 +25,6 @@ Making a Release 4. Create a tag on release branch, either on GitHub or locally. 5. Make a release on GitHub tag page, which might be done with previous step if the tag is created on GitHub. 6. Submit pip, CRAN, and Maven packages. - - The pip package is maintained by [Hyunsu Cho](http://hyunsu-cho.io/) and [Jiaming Yuan](https://github.com/trivialfis). There's a helper script for downloading pre-built wheels on ``xgboost/dev/release-pypi.py`` along with simple instructions for using ``twine``. + - The pip package is maintained by [Hyunsu Cho](http://hyunsu-cho.io/) and [Jiaming Yuan](https://github.com/trivialfis). There's a helper script for downloading pre-built wheels and R packages ``xgboost/dev/release-pypi-r.py`` along with simple instructions for using ``twine``. - The CRAN package is maintained by [Tong He](https://github.com/hetong007). - - The Maven package is maintained by [Nan Zhu](https://github.com/CodingCat). + - The Maven package is maintained by [Nan Zhu](https://github.com/CodingCat) and [Hyunsu Cho](http://hyunsu-cho.io/).