Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Clean up warnings (#6325)

Browse Source
This commit is contained in:
Igor Moura
2020-10-30 12:50:29 -03:00
committed by GitHub
parent f0fe18fc28
commit 5e1e972aea
16 changed files with 53 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/metric/metric.cc
View File

@@ -11,7 +11,7 @@
namespace xgboost {
template <typename MetricRegistry>
Metric* CreateMetricImpl(const std::string& name, GenericParameter const* tparam) {
Metric* CreateMetricImpl(const std::string& name) {
std::string buf = name;
std::string prefix = name;
const char* param;
@@ -44,7 +44,7 @@ Metric* CreateMetricImpl(const std::string& name, GenericParameter const* tparam
Metric *
Metric::Create(const std::string& name, GenericParameter const* tparam) {
auto metric = CreateMetricImpl<MetricReg>(name, tparam);
auto metric = CreateMetricImpl<MetricReg>(name);
if (metric == nullptr) {
LOG(FATAL) << "Unknown metric function " << name;
}
@@ -55,7 +55,7 @@ Metric::Create(const std::string& name, GenericParameter const* tparam) {
Metric *
GPUMetric::CreateGPUMetric(const std::string& name, GenericParameter const* tparam) {
auto metric = CreateMetricImpl<MetricGPUReg>(name, tparam);
auto metric = CreateMetricImpl<MetricGPUReg>(name);
if (metric == nullptr) {
LOG(WARNING) << "Cannot find a GPU metric builder for metric " << name
<< ". Resorting to the CPU builder";

16
src/metric/rank_metric.cc
View File

@@ -55,13 +55,13 @@ class PerInstanceWeightPolicy {
public:
inline static xgboost::bst_float
GetWeightOfInstance(const xgboost::MetaInfo& info,
unsigned instance_id, unsigned group_id) {
unsigned instance_id, unsigned) {
return info.GetWeight(instance_id);
}
inline static xgboost::bst_float
GetWeightOfSortedRecord(const xgboost::MetaInfo& info,
const PredIndPairContainer& rec,
unsigned record_id, unsigned group_id) {
unsigned record_id, unsigned) {
return info.GetWeight(rec[record_id].second);
}
};
@@ -70,14 +70,14 @@ class PerGroupWeightPolicy {
public:
inline static xgboost::bst_float
GetWeightOfInstance(const xgboost::MetaInfo& info,
unsigned instance_id, unsigned group_id) {
unsigned, unsigned group_id) {
return info.GetWeight(group_id);
}
inline static xgboost::bst_float
GetWeightOfSortedRecord(const xgboost::MetaInfo& info,
const PredIndPairContainer& rec,
unsigned record_id, unsigned group_id) {
const PredIndPairContainer&,
unsigned, unsigned group_id) {
return info.GetWeight(group_id);
}
};
@@ -651,11 +651,11 @@ XGBOOST_REGISTER_METRIC(AMS, "ams")
XGBOOST_REGISTER_METRIC(Auc, "auc")
.describe("Area under curve for both classification and rank.")
.set_body([](const char* param) { return new EvalAuc(); });
.set_body([](const char*) { return new EvalAuc(); });
XGBOOST_REGISTER_METRIC(AucPR, "aucpr")
.describe("Area under PR curve for both classification and rank.")
.set_body([](const char* param) { return new EvalAucPR(); });
.set_body([](const char*) { return new EvalAucPR(); });
XGBOOST_REGISTER_METRIC(Precision, "pre")
.describe("precision@k for rank.")
@@ -671,6 +671,6 @@ XGBOOST_REGISTER_METRIC(MAP, "map")
XGBOOST_REGISTER_METRIC(Cox, "cox-nloglik")
.describe("Negative log partial likelihood of Cox proportioanl hazards model.")
.set_body([](const char* param) { return new EvalCox(); });
.set_body([](const char*) { return new EvalCox(); });
} // namespace metric
} // namespace xgboost