Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

rank_metric.cc: Use GetWeight in EvalAMS

Browse Source 
The GetWeight is a wrapper which sets the correct weight
if the weights vector is not provided. Hence accessing the default
weights vector is not recommended.
This commit is contained in:
AbdealiJK 2016-12-04 14:00:57 +05:30 committed by Tianqi Chen
parent 4a2ef130a7
commit 5912e051b1
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/metric/rank_metric.cc
View File

@ -33,7 +33,6 @@ struct EvalAMS : public Metric {
using namespace std; // NOLINT(*) using namespace std; // NOLINT(*)
const bst_omp_uint ndata = static_cast<bst_omp_uint>(info.labels.size()); const bst_omp_uint ndata = static_cast<bst_omp_uint>(info.labels.size());
CHECK_EQ(info.weights.size(), ndata) << "we need weight to evaluate ams";
std::vector<std::pair<bst_float, unsigned> > rec(ndata); std::vector<std::pair<bst_float, unsigned> > rec(ndata);
#pragma omp parallel for schedule(static) #pragma omp parallel for schedule(static)
@ -48,7 +47,7 @@ struct EvalAMS : public Metric {
double s_tp = 0.0, b_fp = 0.0, tams = 0.0; double s_tp = 0.0, b_fp = 0.0, tams = 0.0;
for (unsigned i = 0; i < static_cast<unsigned>(ndata-1) && i < ntop; ++i) { for (unsigned i = 0; i < static_cast<unsigned>(ndata-1) && i < ntop; ++i) {
const unsigned ridx = rec[i].second; const unsigned ridx = rec[i].second;
const bst_float wt = info.weights[ridx]; const bst_float wt = info.GetWeight(ridx);
if (info.labels[ridx] > 0.5f) { if (info.labels[ridx] > 0.5f) {
s_tp += wt; s_tp += wt;
} else { } else {