From 53b5cd73f20ecd5cb0a6c9d1bb3176411e0f5f13 Mon Sep 17 00:00:00 2001 From: amdsc21 <96135754+amdsc21@users.noreply.github.com> Date: Wed, 8 Mar 2023 03:42:51 +0100 Subject: [PATCH] add hip flags --- cmake/Utils.cmake | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/cmake/Utils.cmake b/cmake/Utils.cmake index 3a66735fe..31e8c16db 100644 --- a/cmake/Utils.cmake +++ b/cmake/Utils.cmake @@ -184,6 +184,27 @@ function(xgboost_set_cuda_flags target) CUDA_SEPARABLE_COMPILATION OFF) endfunction(xgboost_set_cuda_flags) +# Set HIP related flags to target. +function(xgboost_set_hip_flags target) + if (USE_DEVICE_DEBUG) + target_compile_options(${target} PRIVATE + $<$,$>:-G>) + endif (USE_DEVICE_DEBUG) + + if (NOT BUILD_WITH_HIP_CUB) + target_compile_definitions(${target} PRIVATE -DXGBOOST_USE_HIP=1 -DTHRUST_IGNORE_CUB_VERSION_CHECK=1) + target_include_directories(${target} PRIVATE ${xgboost_SOURCE_DIR}/rocgputreeshap) + else () + target_compile_definitions(${target} PRIVATE -DXGBOOST_USE_HIP=1) + target_include_directories(${target} PRIVATE ${xgboost_SOURCE_DIR}/rocgputreeshap) + endif (NOT BUILD_WITH_HIP_CUB) + + set_target_properties(${target} PROPERTIES + HIP_STANDARD 17 + HIP_STANDARD_REQUIRED ON + HIP_SEPARABLE_COMPILATION OFF) +endfunction(xgboost_set_hip_flags) + macro(xgboost_link_nccl target) if (BUILD_STATIC_LIB) target_include_directories(${target} PUBLIC ${NCCL_INCLUDE_DIR}) @@ -218,6 +239,10 @@ macro(xgboost_target_properties target) -Xcompiler=-Wall -Xcompiler=-Wextra -Xcompiler=-Wno-expansion-to-defined, -Wall -Wextra -Wno-expansion-to-defined> ) + target_compile_options(${target} PUBLIC + $, + -Wall -Wextra > + ) endif(ENABLE_ALL_WARNINGS) target_compile_options(${target} @@ -285,6 +310,10 @@ macro(xgboost_target_link_libraries target) xgboost_set_cuda_flags(${target}) endif (USE_CUDA) + if (USE_HIP) + xgboost_set_hip_flags(${target}) + endif (USE_HIP) + if (PLUGIN_RMM) target_link_libraries(${target} PRIVATE rmm::rmm) endif (PLUGIN_RMM)