Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[R-package] fixed uses of class() (#5426)

Browse Source 
Thank you a lot. Good catch!
This commit is contained in:
James Lamb 2020-03-20 08:51:20 -05:00 committed by GitHub
parent abca9908ba
commit 4b7e2b7bff
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
R-package/R/utils.R
View File

@ -28,7 +28,7 @@ NVL <- function(x, val) {
# Merges booster params with whatever is provided in ... # Merges booster params with whatever is provided in ...
# plus runs some checks # plus runs some checks
check.booster.params <- function(params, ...) { check.booster.params <- function(params, ...) {
if (typeof(params) != "list") if (!identical(class(params), "list"))
stop("params must be a list") stop("params must be a list")
# in R interface, allow for '.' instead of '_' in parameter names # in R interface, allow for '.' instead of '_' in parameter names
@ -78,7 +78,7 @@ check.booster.params <- function(params, ...) {
if (!is.null(params[['interaction_constraints']]) && if (!is.null(params[['interaction_constraints']]) &&
typeof(params[['interaction_constraints']]) != "character"){ typeof(params[['interaction_constraints']]) != "character"){
# check input class # check input class
if (class(params[['interaction_constraints']]) != 'list') stop('interaction_constraints should be class list') if (!identical(class(params[['interaction_constraints']]),'list')) stop('interaction_constraints should be class list')
if (!all(unique(sapply(params[['interaction_constraints']], class)) %in% c('numeric','integer'))) { if (!all(unique(sapply(params[['interaction_constraints']], class)) %in% c('numeric','integer'))) {
stop('interaction_constraints should be a list of numeric/integer vectors') stop('interaction_constraints should be a list of numeric/integer vectors')
} }