Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix build for AppleClang 11 (#9684) (#9693)

Browse Source
This commit is contained in:
Philip Hyunsu Cho 2023-10-18 12:27:21 -07:00 committed by GitHub
parent 5d1bcde719
commit 3b86260b50
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/common/ref_resource_view.h
View File

@ -76,7 +76,7 @@ class RefResourceView {
[[nodiscard]] size_type size() const { return size_; } // NOLINT [[nodiscard]] size_type size() const { return size_; } // NOLINT
[[nodiscard]] size_type size_bytes() const { // NOLINT [[nodiscard]] size_type size_bytes() const { // NOLINT
return Span{data(), size()}.size_bytes(); return Span<const value_type>{data(), size()}.size_bytes();
} }
[[nodiscard]] value_type* data() { return ptr_; }; // NOLINT [[nodiscard]] value_type* data() { return ptr_; }; // NOLINT
[[nodiscard]] value_type const* data() const { return ptr_; }; // NOLINT [[nodiscard]] value_type const* data() const { return ptr_; }; // NOLINT

3
tests/cpp/common/test_io.cc
View File

@ -144,7 +144,8 @@ TEST(IO, Resource) {
fout << 1.0 << std::endl; fout << 1.0 << std::endl;
fout.close(); fout.close();
auto resource = std::make_shared<MmapResource>(path, 0, sizeof(double)); auto resource = std::shared_ptr<MmapResource>{
new MmapResource{path, 0, sizeof(double)}};
ASSERT_EQ(resource->Size(), sizeof(double)); ASSERT_EQ(resource->Size(), sizeof(double));
ASSERT_EQ(resource->Type(), ResourceHandler::kMmap); ASSERT_EQ(resource->Type(), ResourceHandler::kMmap);
ASSERT_EQ(resource->DataAs<double>()[0], val); ASSERT_EQ(resource->DataAs<double>()[0], val);