Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Added test_lint to test code quality

Browse Source
This commit is contained in:
terrytangyuan 2015-10-24 16:39:58 -04:00
parent 36927632c5
commit 3abbd7b4c7
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
R-package/R/getinfo.xgb.DMatrix.R
View File

@ -35,7 +35,7 @@ getinfo <- function(object, ...){
#' @param ... other parameters #' @param ... other parameters
#' @rdname getinfo #' @rdname getinfo
#' @method getinfo xgb.DMatrix #' @method getinfo xgb.DMatrix
setMethod("getinfo", signature = "xgb.DMatrix", setMethod("getinfo", signature = "xgb.DMatrix",
definition = function(object, name) { definition = function(object, name) {
if (typeof(name) != "character") { if (typeof(name) != "character") {
stop("xgb.getinfo: name must be character") stop("xgb.getinfo: name must be character")
@ -43,7 +43,7 @@ setMethod("getinfo", signature = "xgb.DMatrix",
if (class(object) != "xgb.DMatrix") { if (class(object) != "xgb.DMatrix") {
stop("xgb.setinfo: first argument dtrain must be xgb.DMatrix") stop("xgb.setinfo: first argument dtrain must be xgb.DMatrix")
} }
if (name != "label" && name != "weight" && if (name != "label" && name != "weight" &&
name != "base_margin" && name != "nrow") { name != "base_margin" && name != "nrow") {
stop(paste("xgb.getinfo: unknown info name", name)) stop(paste("xgb.getinfo: unknown info name", name))
} }
@ -54,4 +54,3 @@ setMethod("getinfo", signature = "xgb.DMatrix",
} }
return(ret) return(ret)
}) })

6
R-package/R/predict.xgb.Booster.handle.R
View File

@ -5,14 +5,14 @@
#' @param object Object of class "xgb.Boost.handle" #' @param object Object of class "xgb.Boost.handle"
#' @param ... Parameters pass to \code{predict.xgb.Booster} #' @param ... Parameters pass to \code{predict.xgb.Booster}
#' #'
setMethod("predict", signature = "xgb.Booster.handle", setMethod("predict", signature = "xgb.Booster.handle",
definition = function(object, ...) { definition = function(object, ...) {
if (class(object) != "xgb.Booster.handle"){ if (class(object) != "xgb.Booster.handle"){
stop("predict: model in prediction must be of class xgb.Booster.handle") stop("predict: model in prediction must be of class xgb.Booster.handle")
} }
bst <- xgb.handleToBooster(object) bst <- xgb.handleToBooster(object)
ret = predict(bst, ...) ret = predict(bst, ...)
return(ret) return(ret)
}) })