Improve HostDeviceVector exception safety (#4301)

* make the assignments of HostDeviceVector exception safe.
* storing a dummy GPUDistribution instance in HDV for CPU based code.
* change testxgboost binary location to build directory.
This commit is contained in:
sriramch
2019-03-31 07:48:58 -07:00
committed by Jiaming Yuan
parent 680a1b36f3
commit 2f7087eba1
8 changed files with 36 additions and 30 deletions

View File

@@ -5,4 +5,4 @@ cd python-package
python setup.py install --user
cd ..
pytest -v -s --fulltrace -m "(not mgpu) and (not slow)" tests/python-gpu
./testxgboost --gtest_filter=-*.MGPU_*
./build/testxgboost --gtest_filter=-*.MGPU_*

View File

@@ -5,7 +5,7 @@ cd python-package
python setup.py install --user
cd ..
pytest -v -s --fulltrace -m "(not slow) and mgpu" tests/python-gpu
./testxgboost --gtest_filter=*.MGPU_*
./build/testxgboost --gtest_filter=*.MGPU_*
cd tests/distributed
./runtests-gpu.sh

View File

@@ -123,8 +123,8 @@ if [ ${TASK} == "cmake_test" ]; then
PLUGINS="-DPLUGIN_LZ4=ON -DPLUGIN_DENSE_PARSER=ON"
cmake .. -DGOOGLE_TEST=ON -DGTEST_ROOT=$PWD/../gtest/ ${PLUGINS}
make
cd ..
./testxgboost
cd ..
rm -rf build
fi
@@ -170,10 +170,10 @@ if [ ${TASK} == "sanitizer_test" ]; then
-DCMAKE_CXX_FLAGS="-fuse-ld=gold" \
-DCMAKE_C_FLAGS="-fuse-ld=gold"
make
cd ..
export ASAN_SYMBOLIZER_PATH=$(which llvm-symbolizer)
ASAN_OPTIONS=symbolize=1 ./testxgboost
cd ..
rm -rf build
exit 0
fi