Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #28 from randomjohnnyh/master

Browse Source 
Use getaddrinfo instead of gethostbyname for thread safety
This commit is contained in:
Tianqi Chen 2016-07-27 10:40:24 -07:00 committed by GitHub
commit 2dd7476ad7
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/socket.h
View File

@ -57,12 +57,17 @@ struct SockAddr {
* \param port the port of address * \param port the port of address
*/ */
inline void Set(const char *host, int port) { inline void Set(const char *host, int port) {
hostent *hp = gethostbyname(host); addrinfo hints;
Check(hp != NULL, "cannot obtain address of %s", host); memset(&hints, 0, sizeof(hints));
memset(&addr, 0, sizeof(addr)); hints.ai_family = AF_INET;
addr.sin_family = AF_INET; hints.ai_protocol = SOCK_STREAM;
addrinfo *res = NULL;
int sig = getaddrinfo(host, NULL, &hints, &res);
Check(sig == 0 && res != NULL, "cannot obtain address of %s", host);
Check(res->ai_family == AF_INET, "Does not support IPv6");
memcpy(&addr, res->ai_addr, res->ai_addrlen);
addr.sin_port = htons(port); addr.sin_port = htons(port);
memcpy(&addr.sin_addr, hp->h_addr_list[0], hp->h_length); freeaddrinfo(res);
} }
/*! \brief return port of the address*/ /*! \brief return port of the address*/
inline int port(void) const { inline int port(void) const {