Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remove redundant method in expand_entry (#9283)

Browse Source
This commit is contained in:
ZHAOKAI WANG 2023-06-10 05:18:21 +08:00 committed by GitHub
parent 152e2fb072
commit 2b76061659
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/tree/gpu_hist/expand_entry.cuh
View File

@ -42,12 +42,6 @@ struct GPUExpandEntry {
return true; return true;
} }
static bool ChildIsValid(const TrainParam& param, int depth, int num_leaves) {
if (param.max_depth > 0 && depth >= param.max_depth) return false;
if (param.max_leaves > 0 && num_leaves >= param.max_leaves) return false;
return true;
}
bst_float GetLossChange() const { bst_float GetLossChange() const {
return split.loss_chg; return split.loss_chg;
} }

6
src/tree/hist/expand_entry.h
View File

@ -26,12 +26,6 @@ struct ExpandEntryImpl {
} }
[[nodiscard]] bst_node_t GetNodeId() const { return nid; } [[nodiscard]] bst_node_t GetNodeId() const { return nid; }
static bool ChildIsValid(TrainParam const& param, bst_node_t depth, bst_node_t num_leaves) {
if (param.max_depth > 0 && depth >= param.max_depth) return false;
if (param.max_leaves > 0 && num_leaves >= param.max_leaves) return false;
return true;
}
[[nodiscard]] bool IsValid(TrainParam const& param, bst_node_t num_leaves) const { [[nodiscard]] bool IsValid(TrainParam const& param, bst_node_t num_leaves) const {
return static_cast<Impl const*>(this)->IsValidImpl(param, num_leaves); return static_cast<Impl const*>(this)->IsValidImpl(param, num_leaves);
} }