Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Check correct dump format for gblinear. (#10831)

Browse Source
This commit is contained in:
Jiaming Yuan 2024-09-21 00:32:52 +08:00 committed by GitHub
parent 24241ed6e3
commit 2a37a8880c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 20 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/gbm/gblinear_model.h
View File

@ -125,7 +125,7 @@ class GBLinearModel : public Model {
} }
} }
fo << std::endl << " ]" << std::endl << " }"; fo << std::endl << " ]" << std::endl << " }";
} else { } else if (format == "text") {
fo << "bias:\n"; fo << "bias:\n";
for (int gid = 0; gid < ngroup; ++gid) { for (int gid = 0; gid < ngroup; ++gid) {
fo << this->Bias()[gid] << std::endl; fo << this->Bias()[gid] << std::endl;
@ -136,6 +136,8 @@ class GBLinearModel : public Model {
fo << (*this)[i][gid] << std::endl; fo << (*this)[i][gid] << std::endl;
} }
} }
} else {
LOG(FATAL) << "Dump format `" << format << "` is not supported by the gblinear model.";
} }
std::vector<std::string> v; std::vector<std::string> v;
v.push_back(fo.str()); v.push_back(fo.str());

26
tests/cpp/gbm/test_gblinear.cc
View File

@ -1,21 +1,18 @@
/*! /**
* Copyright 2019 by Contributors * Copyright 2019-2024, XGBoost Contributors
*/ */
#include <gtest/gtest.h> #include <gtest/gtest.h>
#include <xgboost/feature_map.h> // for FeatureMap
#include <memory> #include <memory>
#include <sstream>
#include "../helpers.h" #include "../helpers.h"
#include "xgboost/context.h" #include "xgboost/context.h"
#include "xgboost/gbm.h" #include "xgboost/gbm.h"
#include "xgboost/json.h" #include "xgboost/json.h"
#include "xgboost/learner.h" #include "xgboost/learner.h"
#include "xgboost/logging.h"
namespace xgboost {
namespace gbm {
namespace xgboost::gbm {
TEST(GBLinear, JsonIO) { TEST(GBLinear, JsonIO) {
size_t constexpr kRows = 16, kCols = 16; size_t constexpr kRows = 16, kCols = 16;
@ -40,5 +37,16 @@ TEST(GBLinear, JsonIO) {
ASSERT_EQ(weights.size(), 17); ASSERT_EQ(weights.size(), 17);
} }
} }
} // namespace gbm
} // namespace xgboost TEST(GBLinear, Dump) {
Context ctx;
size_t constexpr kRows = 16, kCols = 16;
LearnerModelParam mparam{MakeMP(kCols, .5, 1)};
std::unique_ptr<GradientBooster> gbm{
CreateTrainedGBM("gblinear", Args{}, kRows, kCols, &mparam, &ctx)};
FeatureMap fmap;
ASSERT_THAT([&] { [[maybe_unused]] auto vec = gbm->DumpModel(fmap, true, "dot"); },
GMockThrow(R"(`dot` is not supported)"));
}
} // namespace xgboost::gbm